search

featurehub-io / featurehub

FeatureHub - cloud native feature flags, A/B testing and remote configuration service. Real-time streaming feature updates. Provided with Java, JavaScript, React, Python, Go, .Net, Ruby, Android, Swift and Flutter SDKs.
https://www.featurehub.io
Other
308 stars 32 forks source link

Last login details not showing and all users are getting access to FeatureHub #698

Closed shrish789 closed 2 years ago

shrish789 commented 2 years ago

Describe the bug

  1. Last Login details are not shown for the users who have logged in using Google/Github/Jio(Our Employer). The details are being shown for those users who have been created by the super-user.

  2. Every user is able to login into FeatureHub right now but it should only be allowed to those who are already created in the system by super-user or admin.

    Which area does this issue belong to? FeatureHub Web Admin app.

To Reproduce Steps to reproduce the behavior:

  1. Login using Google/Github/Azure
  2. Check the last login details of the above user. {The details would be empty}

Expected behavior

  1. Last login details should be visible for all users
  2. Only those users should be granted access to Site which are already created
Screenshot 2022-02-04 at 11 36 13 AM

Versions

IrinaSouth commented 2 years ago
  1. Definitely an issue for external oauth providers users.
  2. This is expected, there is a setting in the mr properties file to disable such behavior by setting auth.userMustBeCreatedFirst=true. (false by default). However there is a related bug https://github.com/featurehub-io/featurehub/issues/452
IrinaSouth commented 2 years ago

both fixes are now in docker version [1.5.7-RC]

shrish789 commented 2 years ago

Thanks for fixing these issues.