search

featurist / browser-monkey

Reliable DOM testing
https://browsermonkey.org
53 stars 6 forks source link

should not be scoped to `body` #49

Closed refractalize closed 7 years ago

refractalize commented 8 years ago

I've seen a couple of issues where people are doing browser.find('body') and not finding it. Seems a fairly natural first test. We should scope to document, not document.body.

dereke commented 8 years ago

I think I made this default to body to make it consistent across iframe/window, I think there was an issue scoping to contentDocument

refractalize commented 8 years ago

yeah i think we made the iframe scope the same as the normal window scope. But actually we should have done it the other way around.

On 21 Sep 2016, at 13:49, Derek Ekins notifications@github.com wrote:

I think I made this default to body to make it consistent across iframe/window, I think there was an issue scoping to contentDocument

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/featurist/browser-monkey/issues/49#issuecomment-248588336, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHkDc5thO3Fg4lo1n4uzNgLtiN0FZV8ks5qsRm5gaJpZM4KCgYh.

dereke commented 8 years ago

haha yeah maybe, should try it and see I suppose

dereke commented 7 years ago

this has been implemented in #65