search

febiosoftware / FEBio

FEBio Suite Solver
https://febio.org/
MIT License
184 stars 68 forks source link

Fixed typos in FEBioFluid subdirectory #66

Closed luzpaz closed 1 year ago

luzpaz commented 1 year ago

Various source comment typo fixes within FEBioFluid/

michaelrossherron commented 1 year ago

I appreciate the corrections done in this pull request. However, on line 251 of FEBioFluid.cpp, you changed a type string of one of the registered classes. These type strings are used to instantiate classes that have been registered to the FEBio Kernel, and changing them will break compatibility with any .feb and .fs2 files that use this class.

I'm not sure how often this particular class is used, so I'm not really sure whether changing this will cause many problems. Unfortunately both our lead developer, and the developer who created this class are out of town, so until they get back, I'm going to shelve this request.

luzpaz commented 1 year ago

I can revert whatever you want. There is also no rush

michaelrossherron commented 1 year ago

Gerard confirmed that the type-string change wouldn't cause problems, so I accepted this request.