search

fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
97 stars 39 forks source link

Make sure odd-numbered special election years work correctly on candidate's "election" drop down #1644

Closed AmyKort closed 6 years ago

AmyKort commented 6 years ago

To make make the election year (election period) more clear to users, we should include both the odd and even year in the drop down option's text.

Our data is generally aggregated by two-year periods, a candidate running for election in 2017 would still show 2017-2018 data. ( for example, https://www.fec.gov/data/candidate/S0AL00156/?cycle=2002&election_full=false )

Completion criteria:

image

Related Issues:

lbeaufort commented 6 years ago

@PaulClark2 here's the WIP PR to pass only even years: https://github.com/18F/fec-cms/pull/1677

PaulClark2 commented 6 years ago

We might be able to borrow text from the statistical releases. They include language that explicitly explains we include special elections in our financial summary data. See the last sentence of paragraphs three and four of Section II. Congressional candidates, https://www.fec.gov/updates/statistical-summary-six-month-campaign-activity-2017-2018-election-cycle/.

We might use something a little more generic, like this, "These totals include financial activity of special elections."

@AmyKort

cptechiegal commented 6 years ago

Project open seat and special election spreadsheet (from Paul Clark) https://drive.google.com/drive/folders/1shCZ_Dul8nSX8ykS8VGTqOWWIhtXT07X

example1: Special Election on December 12, 2017 for Jeff Sessions open seat 2017 2014-2019 senate term (https://en.wikipedia.org/wiki/Jeff_Sessions) Jeff Sessions seat was for the 2014-2020 senate class 2 term

Senate Candidate Doug Jones (won seat) https://www.fec.gov/data/candidate/S0AL00156 Seems to be correct now in Prod since Elections pulldown option is showing correctly as 2018 (had been incorrect as 2017 in the past)

Opponent Senate Candidate Luther Strange https://www.fec.gov/data/candidate/S8AL00308/ Seems to be correct in Prod since Elections pulldown option is showing correctly as 2018 Time period is 2013-2018 Coverage dates are 2016-2017

example2: Ed Markey special election: June 25, 2013 https://www.fec.gov/data/candidate/S4MA00028/ Displays 2014 - however data does not have 2013 in elections list. Created issue#https://github.com/18F/fec-cms/issues/2882

example: Tom Price open seat 2017 2016-2017 house term - (https://en.wikipedia.org/wiki/Tom_Price_(American_politician)#Elections)

House Candidate Karen Handel (won seat) https://www.fec.gov/data/candidate/H8GA06286 Elections pulldown options is showing as 2017 (requested be 2018 for even election year) Time period of 2016-2017 should be 2017-2018 Coverage dates range from 2017-2017

Opponent House Candidate Jonathan Ossoff https://www.fec.gov/data/candidate/H8GA06195/ Elections pulldown options is showing as 2017 (requested be 2018 for even election year) Time period of 2016-2017 should be 2017-2018 However, Coverage dates range from 2016-2017 period

cptechiegal commented 6 years ago

This issue 1644 requests to change the odd year Special Election year to even number year and PR 1708 accomplishes that, which would makes the 2017 display as 2018.

Example: House Special Election 2017 House Candidate Karen Handel (won seat)

@AmyKort and @PaulClark2 Design clarification needed to confirm change was what was expected. Which design choice is preferred for Candidate Summary page? (This also impacts the About and Opposing Candidates pages) 1) Election pull down menu display of even year Election year (i.e., 2018) when Special Election is odd numbered year (i.e., 2017) and then display time period: 2017-2018 2) Election pull down menu display of odd year Special Election year (i.e., 2017) and then display time period: 2017-2018

Option 1) was implemented for this issue currently as PR1708

cptechiegal commented 6 years ago

Also, need clarification on the following: 1) where to display on the webpage the text explaining what's included and 2) the final text to display

patphongs commented 6 years ago

We might be able to borrow text from the statistical releases. They include language that explicitly explains we include special elections in our financial summary data. See the last sentence of paragraphs three and four of Section II. Congressional candidates, https://www.fec.gov/updates/statistical-summary-six-month-campaign-activity-2017-2018-election-cycle/.

We might use something a little more generic, like this, "These totals include financial activity of special elections."

@AmyKort

@JonellaCulmer there appears to be a design task here for one of the completion criterion for this ticket. Product owners have requested the ability to add text explaining what's included in the election years i.e., special elections (2017). Is there an existing design pattern you think we can use for this? cc @PaulClark2 @AmyKort @cptechiegal

jwchumley commented 6 years ago

Paul and I are both OK with implementing the code as it is in the current PR. Even numbered years in the pull down include off year elections in the data. If we want to circle back later and improve it that's OK but it's currently broken in production and this makes the data available.

patphongs commented 6 years ago

add text explaining what's included in the election years i.e., special elections (2017) Determine what text to display and where on the screen - design / user research subtask##1732

These 2 completion criteria have been moved over to issue #1732. The rest of this ticket is now complete with PR https://github.com/18F/fec-cms/pull/1708. Closing.