search

fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
97 stars 40 forks source link

green check-icons not showing up for "Current version" reports #1815

Closed johnnyporkchops closed 6 years ago

johnnyporkchops commented 6 years ago

@johnnyporkchops commented on Wed Feb 21 2018

The green check icon that is conditionally added to some Reports datatables for" Current version" reports is not showing up. example page. See screenshot below of local fix.

<i class="icon-circle--check-outline--inline--left"></i>Current version...

I noticed when adding this to an election page (as a test) in the inspector it does show up, getting its style from the compiled elections.css . This was fixed locally by adding @import 'common'; to datatables.scss

Comparing static/scss/elections.scss with /static/scss/datatables.scss shows that datatables.scss is missing @import 'common'; I assume this is the fix, but not being as familiar with the CSS as @jenniferthibault, I would like her or @patphongs to take a look too.

Fixed locally: missing_check_icon1

jenniferthibault commented 6 years ago

Thanks for flagging this! I wish I knew, but off the top of my head, I'm not familiar with what we have to import into the stylesheets. Maybe Pat knows :fingers-crossed:

johnnyporkchops commented 6 years ago

@import 'common'; imports common.scss which has@import 'global-common';, so it could be that@import 'global'; can be removed, but I have not researched how that is concatenated yet.

patphongs commented 6 years ago

PR merged, closing