fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
93 stars 38 forks source link

Add 'memo_total' to disbursement aggregate page? #2490

Open hcaofec opened 5 years ago

hcaofec commented 5 years ago

The data returned by aggregate endpoints has been changed in #3390. Design team may need to look into disbursement aggregate page to decide whether to display total of memoed items

Before: Total + count ( which is actually non memo total and count ) After: non memo total, non memo count; memo total; memo count

disbursements endpoints: /schedules/schedule_b/by_purpose/ /schedules/schedule_b/by_recipient/ /schedules/schedule_b/by_recipient_id/

hcaofec commented 5 years ago

current endpoint: https://api.open.fec.gov/v1/schedules/schedule_b/by_recipient_id/?sort_null_only=false&per_page=20&cycle=2012&page=1&api_key=DEMO_KEY&sort_hide_null=false

screen shot 2018-11-01 at 3 09 39 pm

After-change endpoint: http://127.0.0.1:5000/v1/schedules/schedule_b/by_recipient_id/?per_page=20&page=1&sort_hide_null=false&cycle=2012&sort_null_only=false

screen shot 2018-11-01 at 3 09 16 pm
hcaofec commented 5 years ago

Current disbursement aggregate page:

screen shot 2018-11-01 at 3 10 52 pm