Open cnlucas opened 2 years ago
Committee type labels spreadsheet: https://docs.google.com/spreadsheets/d/1IJOnb0o7MbfVuUklBrHx-4qic7_CpbEt4wmG1mti74Q/edit#gid=798440796
We separate the labels with hyphens while there are also hyphens within the labels on the comm profile page subheader which can make it hard to visually separate where a label starts and ends.
Example : "Corporation"
and "Party - Nonqualified"
are concatenated without a hyphen, then "Unauthorized"
is concatenated to the end with a hyphen. This could be read as Corporation Party
, Nonqualified
, Unauhtorized
.
@patphongs @dorothyyeager @kathycarothers I have some concerns that I didn't notice before in the dev ticket and how data currently exists in the API. For example, we use Qualified and qualified, Nonqualified and nonqualified, and Membership PAC and Membership Organization.
Before moving forward on this, should we address these inconsistencies? For a more complete look, here's the table in the dev ticket and the spreadsheet with all committee types. Dev ticket table: https://github.com/fecgov/openFEC/issues/4915#issuecomment-894446130 Committee type spreadsheet: https://docs.google.com/spreadsheets/d/1IJOnb0o7MbfVuUklBrHx-4qic7_CpbEt4wmG1mti74Q/edit#gid=798440796
Hi Jonella. Agree that we should be consistent with Qualified and Nonqualified. I don't have a strong preference but capitalized makes a little more sense for this.
Membership PAC and Membership Organization are two different things. A Membership PAC is the SSF formed by a Membership Organization.
@dorothyyeager You wouldn't call it a Membership Organization PAC? You'd prefer Membership PAC?
I would prefer Membership Organization PAC. (But I'm not the one who gets to make that call.) I notice in the statistical summaries put out by Press, they are called "membership" no organization.
Maybe we should match Press?
@dorothyyeager @kathycarothers @djgarr Based on the conversation above, I started to update some of these labels. I don't believe all of them require changes but if you see any others that do, feel free to comment here in this ticket or make the changes straight into the spreadsheet. And I'm foregoing any changes that require capitalization because we will force all caps on profile pages. My changes are in red. Feel free to use a different color.
cc: @PaulClark2 @patphongs
I guess I am confused. Are we going to follow Press or not? I think they look fine, but I am confused as to who should make the final decision. I think Membership PAC or Membership Organization PAC was the big one to decide on.
@kathycarothers The membership issue was just one example that I found while looking at the list, but I'd imagine that trade associations and labor organizations would be handled similarly. I'll reach out to whoever you think needs to weigh in on this. I can't believe I can't find a single reference anywhere (other than the one Dorothy found in the statistics).
Although, I wouldn't say that section is consistent with the rest of the site for other terminology, such as their reference to "Corporations without Stock" (and not Capital Stock).
cc: @dorothyyeager @djgarr @AmyKort
We're going to icebox this work for now. We've made previous progress to improve profile pages in the past here, and without making significant changes to the existing committee label work, it isn't enough to satisfy current need.
Summary
Now that we have the new
committee_label
built out in the back-end (thanks Helen!) we need to decide where and how it should be used in the front-end. Also, need to determine what the proper arrangement of the new committee labels we be alongside other labeling so that the committees are appropriately and clearly labeled across all committee types.Considerations:
Resources:
organization_type_full
committee_type_full
designation_full
. SSFs areorganization_type
"W", "C", "L", "V", "M", or "T".committee_type_full
designation_full
committee_type_full
anddesignation_full
, dash only appears if there is adesignation_full
Related Issue
https://github.com/fecgov/openFEC/issues/4915
Action Items