Expand keyword search on /updates to include html content

johnnyporkchops commented 3 months ago

Summary (required)

Resolves #6118
Added search_updates() function to convert the body (on pages with html fields) to a string and do a Python string search on them
Preserve superior existing backend Postgres search for pages with searchable fields types (non-html)
Exclude duplicate search results on rare occurrences where both search options return results for the same query because a page has both html and other database-searchable fields

Required reviewers

one frontend AND one UX or content

Impacted areas of the application

The /updates keyword search modified: home/views.py

Screenshots

Coming soon...

How to test

This has been pushed to dev for testing, check with me to confirm its still live if you are testing there.

checkout and run branch
do a keyword search for a term that appears in an html block of a Digest, PressRelease, Record, or TipsForTreasurers page
- Example search from issue: https://www.fec.gov/updates/?update_type=weekly-digest&search=MUR+6535
do a keyword search for a term not in an html block of a Digest, PressRelease, Record, or TipsForTreasurers page

Note: The html search is a little slower when searching across all updates (Publication type set to All ) , but I am working in innovation sprint to optimize performance for a quicker return time.

JonellaCulmer commented 3 months ago

@kathycarothers Let me know if you'd like to pair on the testing for this.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 77.93%. Comparing base (416e640) to head (35e1ccd). Report is 4 commits behind head on develop.

Files	Patch %	Lines
fec/home/views.py	5.55%	17 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #6214 +/- ## =========================================== - Coverage 78.00% 77.93% -0.08% =========================================== Files 288 288 Lines 9297 9307 +10 Branches 681 681 =========================================== + Hits 7252 7253 +1 - Misses 2045 2054 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kathycarothers commented 2 months ago

@JonellaCulmer yes let's pair for the testing

fecgov / fec-cms