Closed johnnyporkchops closed 2 months ago
@johnnyporkchops Whenever you're ready to push into a testing space, happy to look at it!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.02%. Comparing base (
c09bf89
) to head (48d8b48
). Report is 20 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@
@johnnyporkchops Whenever you're ready to push into a testing space, happy to look at it!
@dorothyyeager , this is on https://stage.fec.gov
for testing
The one thing is that we wanted to link a Record article, but I don't see a way to insert a link into the text. Is there a way to do that?
@dorothyyeager You would add the link the same way you add it to any of the other snippets...with html
Summary (required)
Resolves #6176
Use existing
informational_message
snippet pattern to allow an info/alert banner above intro on resource pageNon-required field added to create/edit template for
embed_snippet
for choosing aninfo(i)
oralert(!)
icon for the banner..Defaults to 'info'Possible future work:
Register a new snippet model for
info/alert
banner and one for a moregeneric snippet
that could be used for theCont limits footnotes
, for example. Currently content team is storing the html for Cont limits footnotes in snippets and pasting it into html blocks on pages instead of using a snippet chooser because of the default styling of the embed snippet template. New snippet patterns would also make the snippets listed separately in the admin, which content team has complained is currently hard to browse and find what your looking for..Required reviewers
One Content Optional: One Dev or UX
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
Info:
Alert:
How to test
-[ ] Remove stage deploy task before merge
Content/UX tem: This is on stage for testing
Developers/UX team:
manage.py migrate
embed snippet
for Contribution limits tables/footnotes/info messages, but you can spot check them to be sure.