codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 77.98%. Comparing base (
3ad02a1) to head (ca82cfe). Report is 18 commits behind head on develop.
| Files | Patch % | Lines |
|---|---|---|
| fec/home/views.py | 7.69% | 12 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #6230 +/- ## =========================================== - Coverage 78.01% 77.98% -0.03% =========================================== Files 289 289 Lines 9347 9350 +3 Branches 681 681 =========================================== Hits 7292 7292 - Misses 2055 2058 +3 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary (required)
Resolves #
Related issue: #6118
Related PR: https://github.com/fecgov/fec-cms/pull/6214
The original PR for resolving un-searchable html in
/updatessearches worked, but the search was noticeably slow when searching across all update-types. This PR speeds that search up.This PR also combines a more inclusive text-search with the existing
wagtail.search.backends.databasesearch forOpen meetiingsandHearingswhich will find more results for all years in addition to resolving the issue of previously unsearchable legacy pages withimported_htmlcontent.Required reviewers
One dev One UX or One Content
Impacted areas of the application
/updatessearches (PressRelease, WeeklyDigest, TipsForTreasurers and Record)Meetings page searches on
/meetingsmodified: home/views.py
How to test
Content/UX: Ask me to push to featiure or dev and see bullets below for testing Developers:
checkout and run branch
Go to
/updatesand search for "MUR 6535" with "All" chosen inPublication type. This should be much faster than the same search on Production.Go to
/meetingsand search "Lorenzo Holloway". You should get more results than on Production, with results going back past 2016.Try other keyword searches for pages older that 2016 for both
/updatesand/meetings.Note:: Prior to this PR, a common pattern for listing Presenters separated by a slash in meeting pages, would not return results when searching individual names if there was not a space before and after the slash. For example, The built in db search will not find Lorenzo Holloway in
Joshua Blume/Lorenzo Hollowaybut it will find it inJoshua Blume / Lorenzo Holloway. With the changes in this PR, searches will return all pages with the presenter's name, regardless of the syntax.