Closed rfultz closed 1 month ago
Attention: Patch coverage is 89.18919%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 78.01%. Comparing base (
e5df5a7
) to head (8624a77
). Report is 2 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
fec/fec/static/js/modules/filters/select-filter.js | 33.33% | 2 Missing :warning: |
fec/fec/static/js/modules/helpers.js | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rfultz One more thing we noticed is that not all the filters (especially the newer ones added here) are not hooked up to the search tags or passed through as URL query parameters. Could you please add this capability so we can remain consistent?
@rfultz We're missing committee clickthroughs to committee profile pages. Clicking on a committee name in the table should take you to their profile page.
cc: @patphongs
@rfultz We're missing committee clickthroughs to committee profile pages. Clicking on a committee name in the table should take you to their profile page.
cc: @patphongs
Will be part of the next commit/push
Summary
Building the front-end for the national party accounts' receipts and disbursements datatables
Required reviewers
Impacted areas of the application
Screenshots
Related PRs
Related PRs against other branches:
None for CMS
Known issues
UX and SMEs: when the right-side details panel is open, it scoots down lower than the table. Should we lose a table column?
How to test
FEC_API_URL
points to stagenpm i
npm run build
./manage.py runserver
Default, with feature flags on for localhost:
To test feature flag:
FEATURES['nat_party_acct_receipts'] = True
, saveFEATURES['nat_party_acct_disbursements'] = True
, save⭐️ Next steps ⭐️
Linked tickets will need updates to stay in sync with the Webpack #2708 upgrade