fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
93 stars 38 forks source link

Document type filter and MUR & ADR UI changes v2 #6286

Closed patphongs closed 4 months ago

patphongs commented 4 months ago

Summary (required)

(Include a summary of proposed changes and connect issue below)

Required reviewers

(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)

Impacted areas of the application

General components of the application that this PR will affect:

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

Related PRs

Related PRs against other branches:

branch PR
fix/other_pr [link]()
feature/other_pr [link]()

How to test

(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (cf19bed) to head (c6527eb). Report is 11 commits behind head on develop.

:exclamation: Current head c6527eb differs from pull request most recent head 1c5f8d6

Please upload reports for the commit 1c5f8d6 to get more accurate results.

Files Patch % Lines
fec/legal/views.py 0.00% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6286 +/- ## =========================================== - Coverage 78.00% 77.86% -0.15% =========================================== Files 291 291 Lines 9414 9431 +17 Branches 681 681 =========================================== Hits 7343 7343 - Misses 2071 2088 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

patphongs commented 4 months ago

Closing pull request due to node_modules complications