The api_caller is currently still searching our api regulations endpoint (which will be removed ) and that is where is gets its results["regulations_returned"] count which differs from the count returned from new eCFR regulations search.
Remove the reference to regulations in api_caller and add results["regulations_returned"] to legal_search() in legal/views.py
Remove tests for api_caller that reference regulations. There are tests for regulations inecfr_caller
Summary (required)
Resolves #6282
The
api_calleris currently still searching our api regulations endpoint (which will be removed ) and that is where is gets itsresults["regulations_returned"]count which differs from the count returned from new eCFR regulations search.Remove the reference to regulations in api_caller and add
results["regulations_returned"]tolegal_search()inlegal/views.pyRemove tests for
api_callerthat reference regulations. There are tests for regulations inecfr_callerRequired reviewers
one team member (frontend, content, UX)
Impacted areas of the application
Legal search boxes on these pages: https://www.fec.gov/data/legal/search/ https://www.fec.gov/legal-resources/
Files changed: modified: data/api_caller.py modified: legal/views.py modified: data/tests/test_legal_search.py
Screenshots
(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)
Related PRs
Related PRs against other branches:
How to test
cd ../to fec-cms directory and runpytest