fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
93 stars 38 forks source link

6292, 6293 ZIP Codes in details panels #6336

Closed rfultz closed 3 months ago

rfultz commented 3 months ago

Summary

Updating the details panels' ZIP Codes for consistency, using "City, state and ZIP code" and the ZIP+4 if it's available.

Required reviewers

Impacted areas of the application

General components of the application that this PR will affect:

Page ZIP Code format ZIP Code label
Allocated federal non-federal disbursements 2
Debts 1 2
Disbursements 2
Loans 1
National party disbursements 1 1
National party receipts 1 1
Receipts 1

Screenshots

Allocated (prod on left, local on right) image

Debts (prod on left) I couldn't find entries with +4 image

Disbursemeents (prod on left) image

Loans (prod on left) I couldn't find entries with +4. Loan Source isn't displaying a ZIP so there's no mention of it. image

National party account disbursements (localhost only) image

National party account receipts (localhost only) image

Receipts (prod on left) image

How to test

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.83%. Comparing base (e95a584) to head (bdbe988).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #6336 +/- ## =========================================== - Coverage 77.84% 77.83% -0.02% =========================================== Files 291 291 Lines 9465 9465 Branches 687 687 =========================================== - Hits 7368 7367 -1 - Misses 2097 2098 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JonellaCulmer commented 3 months ago

@rfultz Everything looks great to me. I didn't find any additional places for the changes.

Per our chat, for wrapping text, can we set that line height at 1.4 for rows? When messing around in inspector changing the setting changed everything, which made everything tighter, so I want to avoid that.