Closed rfultz closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.83%. Comparing base (
e95a584
) to head (bdbe988
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rfultz Everything looks great to me. I didn't find any additional places for the changes.
Per our chat, for wrapping text, can we set that line height at 1.4 for rows? When messing around in inspector changing the setting changed everything, which made everything tighter, so I want to avoid that.
Summary
Updating the details panels' ZIP Codes for consistency, using "City, state and ZIP code" and the ZIP+4 if it's available.
Required reviewers
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
Allocated (prod on left, local on right)
Debts (prod on left) I couldn't find entries with +4
Disbursemeents (prod on left)
Loans (prod on left) I couldn't find entries with +4. Loan Source isn't displaying a ZIP so there's no mention of it.
National party account disbursements (localhost only)
National party account receipts (localhost only)
Receipts (prod on left)
How to test
npm i
npm run build
./manage.py runserver