fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
97 stars 39 forks source link

Visual design review of new Wagtail pages #819

Closed emileighoutlaw closed 7 years ago

emileighoutlaw commented 7 years ago

This is a continuation of: https://github.com/18F/fec-cms/issues/781, creating Wagtail pages for higher-level content pages that we don't have time to rewrite before the site flip but that we need created. Basically, intermediary pages that will connect the new site to unmigrated content on the legacy site.

These pages use the "resource" template and are ready for Jen's visual design review.

@jenniferthibault, I haven't published these pages yet; if you're willing to look at them in preview mode from Wagtail, that's most convenient for me. If you'd rather have a password-protected, live version of each page, let me know, and I can set that up for you, too!

Pages for review:

Candidates and committee services

Legal resources

Footer

jenniferthibault commented 7 years ago

Candidates and committee services

Legal resources

Footer

jenniferthibault commented 7 years ago

One last thing I forgot, and it's a larger ask:

On the Legislation page, the number of 1st level sections makes the side nav unusable for items further down (which is its main purpose). This screenshot is cut off at the fold on my regular laptop monitor.

screen shot 2017-02-15 at 1 02 39 pm

Would you consider consolidating the HR sections into one with multiple subsections?

emileighoutlaw commented 7 years ago

Jen! Thank you for such thoughtful, fast feedback. This is awesome!

emileighoutlaw commented 7 years ago

Actually, I think I found something that will make your great combine-the-legislation-things idea work. I think this version gets us closer. What do you think?

jenniferthibault commented 7 years ago

Legislation: Yes! Exactly what I was thinking. Still a long nav because of the long section titles, but collapsing the HRs into one works well for now!

Court cases: also YES! Nice elimination of a page.

Links: Doc titles sounds good! Can you add this to your content guidance for future remembering?

Ok to close this issue in favor of you publishing the pages on whatever schedule makes sense? I think the design issues are all resolved.

emileighoutlaw commented 7 years ago

Circling back around on this for @jenniferthibault and @noahmangerโ€”ย think we're ready to pass this off to FEC for review?

noahmanger commented 7 years ago

This is awesome. Just talked to @AmyKort and she's going to review.

emileighoutlaw commented 7 years ago

Fantastic!

AmyKort commented 7 years ago

Generally, these are looking great to us. I think we'll only have a few small wording changes. One issue that jumped out is calling the House of Representatives Bills House of Representatives Bills. The bills listed are HR _____. But we think it might be better to call them "Campaign finance legislation" or something more general. Ideas?

AmyKort commented 7 years ago

For court cases โ€“ The names of the cases should be italicized (GPO Style Manual). (I know they arenโ€™t in italics on the current site but I think they should be there too.)

@emileighoutlaw

emileighoutlaw commented 7 years ago

Fixed the italics, @AmyKort .

And I hear you about the HR section name. I didn't feel great about House of Representatives Bills, and I'm glad to hear that reinforced by your comment. The thing that feels werid about "campaign finance legislation," to me isโ€”ย  isn't everything on the page a kind of campaign finance legislation? Is there any defining feature about the HR _____s that we can use for their section name? ๐Ÿ˜–

AmyKort commented 7 years ago

Ack.

I hear you about the campaign finance legislation label, @emileighoutlaw

They are all Acts of Congress. Could we do something with that?

@amypike Help!

emileighoutlaw commented 7 years ago

Yes! Please help @amypike !

amypike commented 7 years ago

Hmmm. The links are to public laws that amend FECA in some way but some were done through appropriations bills so it is tricky to categorize. The header above is " FECA and Amendment Legislative Histories" so "Recent FECA Amendments" is about the best I can come up with. Can we try that, as a placeholder? @emileighoutlaw @AmyKort

amypike commented 7 years ago

@emileighoutlaw @AmyKort My nice husband suggested "Recent Statutory Updates" or "Developments" or "Changes," if you like those better. They seem more plain language.

emileighoutlaw commented 7 years ago

Nice husbands are the absolute best ๐Ÿ’Ÿ ! I'm going to mull these ideas for a bit, if y'all don't mind!

jenniferthibault commented 7 years ago

@emileighoutlaw since it's feeding into the sitemap issues, wondering what the status of this is? Are they ready to publish?

emileighoutlaw commented 7 years ago

Ah yesโ€”ย I believe we can close this issue as review and publication are being tracked here: https://github.com/18F/fec-cms/issues/845