search

fecgov / fec-eregs

The Federal Election Commission's web-based application that makes regulations easier to find, read and understand.
https://www.fec.gov/regulations/
Other
33 stars 13 forks source link

Fix the missing internal link 1.2 on few rules #393

Open pkfec opened 6 years ago

pkfec commented 6 years ago

Rules that need 1.2 linked: 1.3(b), 1.4(a), 4.5(a)(4)(i) and (iv), 4.7(b)(1), 4.8(c), 5.5(a) and (c), 6.170(d)(3), 6.170(i), 100.19(a), 104.2(b), 104.5(e)(5), 111.4(a), 111.15(a), 111.16(c), 112.1(e), 112.3(d), 200.2(b)(5).

dorothyyeager commented 6 years ago

Missing some of the links still on stage and dev - not sure if it's ready to be tested?

pkfec commented 6 years ago

Not yet. I am still working on this ticket.

pkfec commented 6 years ago

@dorothyyeager

cc : @vrajmohan

dorothyyeager commented 6 years ago

@pkfec 1.3(b) and 1.4(a) have the link, confirmed. Looks good on dev.

Typo on my part - it's 104.3(e)(5) that needs the link (not 104.5). Sorry about that!

pkfec commented 6 years ago
Reg Part/Subparts link to 1.2 Section
1.3(b) works
1.4(a) works
4.5(a)(4)(i) need to fix
4.5(a)(4)(iv) need to fix
4.7(b)(1) need to fix
4.8(c) need to fix
5.5(a) need to fix
5.5(c) need to fix
6.170(d)(3) need to fix
6.170(i) need to fix
100.19(a) need to fix
104.2(b) need to fix
104.3(e)(5) need to fix
111.4(a) need to fix
111.15(a) need to fix
111.16(c) need to fix
112.1(e) need to fix
112.3(d) need to fix
200.2(b)(5) need to fix
pkfec commented 6 years ago

There is bug on the parse that does not allow internal citations visible to other parts of the regulations. @vrajmohan first discovered this on FEC's 2016 regulations and opened https://github.com/eregs/regulations-parser/issues/207

vrajmohan commented 6 years ago

This was actually discovered on EPA regulations :-)

pkfec commented 6 years ago

@vrajmohan suggested 3 possible solutions:

  1. Leave the Parts as is, with out making any changes, and let the user navigate to the right section (1.2).
  2. Create a external citation links on each Part to link to the 1.2 section which navigates the user to a GPO site.
  3. Since this is a known bug on the eregs repo (eregs/regulations-parser#207), and this open source repo is consumed by other agencies (CFPB, EPA etc..), we need more time to analyze/investigate the issue and put a fix on the eregs repo.

@AmyKort will discuss the above proposed solutions with Product Owners/ Business Users and confirm which option works best for FEC.

AmyKort commented 6 years ago

Thanks so much @pkfec and @vrajmohan !

lbeaufort commented 5 years ago

@fec-jli can you add some notes with examples on the broken links you found while loading 2019 regulations?

dorothyyeager commented 5 years ago

@lbeaufort The 1.2 link thing stems from the change of address rulemaking. The Commission basically took every rule that listed the 999 E Street address, and changed it to "address in 1.2". So the missing links covered in this issue are in regs in the left column of the chart at https://github.com/fecgov/fec-eregs/issues/393#issuecomment-385722690. Basically each of those regs has a reference to 1.2 but does not link 1.2.

So for example, if you go to https://www.fec.gov/regulations/112-1/2019-annual-112#112-1-e, 1.2 is referenced there but it's not linked.

The other link issue I found when helping @fec-jli test the 2019 e-regs is that our external links all point to an old GPO link, and need to be reset to point to the newer govinfo one. See this comment and this comment with newer link. I can put a ticket in on this one if needed.

lbeaufort commented 5 years ago

@dorothyyeager thank you for the info! It seems like two separate issues with separate causes to me. @fec-jli if you agree, can you or @dorothyyeager put in a new issue?

fec-jli commented 5 years ago

@lbeaufort @dorothyyeager Laura is correct, this issue is for missing internal link. I have created another issue for broken external link. Thanks https://github.com/fecgov/fec-eregs/issues/446