search

fecgov / fec-pattern-library

Pattern Library for FEC.gov
https://fec-pattern-library.app.cloud.gov/
Other
11 stars 10 forks source link

Consider updating link color #18

Closed jenniferthibault closed 6 years ago

jenniferthibault commented 6 years ago

@noahmanger commented on Wed Nov 02 2016

Our links are currently styled using color: inherit which means that they inherit their color from the color of the parent element. So if the color of a paragraph is black, they'll be black; if it's white (like in a slab), they'll be white.

However, a few people have noted that this makes it hard to tell that they're links: image

I don't know that I'd suggest having a different color when they're on a dark background, but when they're on a white background I think it would be worth making them a more vibrant color.

This came through in @ChristianHilland 's feedback on the press releases, so wanted to file an issue to discuss with @jenniferthibault .

@jenniferthibault commented on Wed Nov 02 2016

Are there other cases where this came up specifically besides the press releases? Not disagreeing at all, but always cautious of generalities and "people are saying". (Which is not what you said, I know!) I'd like to understand other scenarios where this came up to see if there are any times when it's specifically hard to find hyperlinks people are looking for.

@noahmanger commented on Wed Nov 02 2016

I don't have specifics off the top of my head other than that it's caught my eye a few times. I'm not suggesting we make a change on this feedback alone, but wanted to raise it in case you or others agreed.

@emileighoutlaw commented on Thu Nov 03 2016

I'm not sure I have strong feelings either way on this one

@ChristianHilland commented on Thu Nov 03 2016

Just speaking for the Press Office, the hyperlinks are important in news releases on open meeting and litigation matters. Often times, people seek documents that have been discussed at public meetings such as advisory opinions, rulemaking initiatives, etc. To me, it seems that the hyperlinks are not as easily identifiable in the Press section of the beta site. While I'm bringing up the issue, it's not one of great concern.

jenniferthibault commented 6 years ago

Noting for future github archeology: This issue has not been addressed and and was closed as part of a batch of issues that have been iceboxed for an extended period of time.