fecgov / fecfile-project-management

FECFile project management
2 stars 0 forks source link

Please review these wires for 1003, 1011, 1012, & 1005 #66

Closed MitchellTCG closed 1 year ago

MitchellTCG commented 1 year ago

Once you have signed off on the wires here, I can add them to actual tickets

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-59

AureliaKhorsand commented 1 year ago

@MitchellTCG

Feedback on #1003:

Feedback on #1012:

Feedback on #1011:

JonellaCulmer commented 1 year ago

Only caveats: Since we have agreed to use radio buttons if yes/no is optional, I have chosen to use a toggle for Yes/No when data is required. I just want to know should it be defaulted to yes or no?

You seem to be using both radio buttons for required and optional across your mockups. Do you mean we should use radio buttons for required and checkbox for optional? I would support this.

As to the default, in my mind, we have two options. Defaulting to the same option each time, or defaulting to the most commonly used option. The latter meaning that we may have some yes's defaulted and some no's. The latter at the very least sounds like a greater LOE, so for now, let's go with the former and default to the first choice.

The one exception I see might be for the "others liable" since they are providing information in the form that could affect that section.

Also clicking "Add loan guarantor" will open a new section within the Add loan guarantor space.

The guarantor is added to step 1, correct?

"This loan requires a related transaction. Click STEP TWO below to enter loan agreement information."

We should avoid words like "click" and "below". Directional words like below are not inclusive. My preference: "Continue to STEP TWO to add loan agreement information"

Accordion changes.

I like the changes, clarifies what about to happen, what needs to be done, and creates a bit more visual interest. One small edit, we should avoid using the Oxford commas. We avoid them on .gov.

Authorized representative

Don't like that we plan to include authorized representatives in the list of individuals. That doesn't make sense to me. They are not the same thing.

Amount

Instead of "Amount (Original)" can we say "Original amount"?

@AureliaKhorsand "Not seeing a way to see the auto-generated receipt..."

Thanks for bringing that up. I commented on the language drafted in #1178

MitchellTCG commented 1 year ago

1003 Loan Received from Bank - Lender

1003 - Loan Received from Bank.png 1003 - Loan Received from Bank - Terms.png

MitchellTCG commented 1 year ago

1012 C2 Gaurantor

1012 Guarantor – Collapsed.png 1012 Guarantor.png

MitchellTCG commented 1 year ago

1011 C1 - Loan Agreement

Loan Agreement

1011 - Loan Received from Bank – Loan Agreement.png

Term Section

1011 Terms.png 1011 Terms – Credit Amount this Draw.png

Others liable

1011 Others liable.png Reminder that the section is optional but if they select yes blue text will appear below telling the user where to enter guarantor info.

Collateral

1011 Collateral.png

Future income

1011 Future income.png 1011 Future income – Location of account.png

Authorized representative

1011 Authorized representative.png

MitchellTCG commented 1 year ago

1005 Loan Received From Bank on Schedule A

1005 - Loan Received From Bank on Schedule A.png

MitchellTCG commented 1 year ago

@AureliaKhorsand please review

AureliaKhorsand commented 1 year ago

1003 wire looks good. BA approved.

1012 wire looks good. BA approved.

1011 feedback:

  1. Good news everyone! The optional Y/N are now required. We will update the ticket but you can remove "(OPTIONAL)" from those fields.
  2. Text at the bottom should have commas, not semicolons.
  3. If we include a ToolTip for "Location of Account" in the wire, we need to have the text for what it says. I'm okay with implementing this later.

1005:

  1. Text at the top says to return to previous step to update loan information, but really it's Step One they have to return to.
  2. I notice the button says "Save Transactions". What will be our rule for using this language vs "Save" vs "Save both transactions"?
MitchellTCG commented 1 year ago

Re: 1003 - Ok Re: 1012 - Ok Re: 1011 -

  1. Duly noted and updated
  2. Although Grammarly and I deeply believe in the use of the semicolon, I have replaced it with commas.
  3. Let make a differ ticket for that.

Re: 1005

  1. Fixed
  2. it will be Save and Save transactions. (I did not know we would have transactions with more than two accordion sections)
AureliaKhorsand commented 1 year ago

Closing as complete since we have finished the initial loan implementation.