Review and confirm unit test coverage for F1M in .fec

[exalate-issue-sync[bot]]

As the functionality of the site has increased and changed, the validity of the creation of the Form 1M row of the *.fec file should be confirmed.

The task of this ticket is to check and expand the *.fec file unit test coverage of the Form 1M row for all fields in the spec.

 

Spec: https://docs.google.com/spreadsheets/d/153u1rGx9FBijnANX_2KMh3iBppVVK8ge/edit?gid=1752884741#gid=1752884741

Transform file: https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/web_services/dot_fec/schema_fields/F1M.json

QA Notes

Fields can be verified by viewing the Print Preview.

DEV Notes

When this ticket is implemented, please note [https://fecgov.atlassian.net/browse/FECFILE-1641|https://fecgov.atlassian.net/browse/FECFILE-1641|smart-link] that needs to be retested and potentially resolved.

Design

null

See full ticket and images here: FECFILE-1587

[exalate-issue-sync[bot]]

Todd Lees commented: Comment in PR. moving back to in-progress

[exalate-issue-sync[bot]]

Sasha Dresden commented: API PR: https://github.com/fecgov/fecfile-web-api/pull/1137 Validate PR: https://github.com/fecgov/fecfile-validate/pull/325

Had to fix col seq order in the validate project to address this so there's now 2 PRs.

[exalate-issue-sync[bot]]

Todd Lees commented: Passes CR moving to QA

[exalate-issue-sync[bot]]

Todd Lees commented: Unit tests:

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4425/workflows/cf473913-f4dc-4c50-a7ef-744407523191/jobs/12876|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4425/workflows/cf473913-f4dc-4c50-a7ef-744407523191/jobs/12876]

!image-20241022-210352.png|width=1391,height=590,alt="image-20241022-210352.png"!

[exalate-issue-sync[bot]]

Shelly Wise commented: QA review verified unit tests passing for this ticket.

QA Review Completed. Moved to Stage Ready.