search

fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Review and confirm unit test coverage for Schedule B in .fec #1068

Open exalate-issue-sync[bot] opened 1 month ago

exalate-issue-sync[bot] commented 1 month ago

As the functionality of the site has increased and changed, the validity of the creation of the Schedule B row of the *.fec file should be confirmed.

The task of this ticket is to check and expand the *.fec file unit test coverage of the Schedule B for all fields in the spec.

Spec: https://docs.google.com/spreadsheets/d/153u1rGx9FBijnANX_2KMh3iBppVVK8ge/edit?gid=1640168660#gid=1640168660

Transform file: https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/web_services/dot_fec/schema_fields/SchB.json

QA Notes

Fields can be verified by viewing the Print Preview.

DEV Notes

Archived Transaction Group document [https://docs.google.com/spreadsheets/d/1lR2LsGrZMYzwfxHPByKH-roqaGktVla2nBShRlZTqCU/edit?usp=sharing|https://docs.google.com/spreadsheets/d/1lR2LsGrZMYzwfxHPByKH-roqaGktVla2nBShRlZTqCU/edit?usp=sharing|smart-link]

Design

null

See full ticket and images here: FECFILE-1591

exalate-issue-sync[bot] commented 4 days ago

Sasha Dresden commented: Double checking validate schema against spec

exalate-issue-sync[bot] commented 4 days ago

Sasha Dresden commented: Double checked against spec and validate schema seems to match.

exalate-issue-sync[bot] commented 1 day ago

Elaine Krauss commented: For QA: passing unit tests can be found [here|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4412/workflows/dadfc68a-dbd8-41bc-9646-ce3aafffc3b6/jobs/12860]