search

fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Review and confirm unit test coverage for Schedule C in .fec #1069

Closed exalate-issue-sync[bot] closed 1 week ago

exalate-issue-sync[bot] commented 1 month ago

As the functionality of the site has increased and changed, the validity of the creation of the Schedule C row of the *.fec file should be confirmed.

The task of this ticket is to check and expand the *.fec file unit test coverage of the Schedule C for all fields in the spec.

Spec: https://docs.google.com/spreadsheets/d/153u1rGx9FBijnANX_2KMh3iBppVVK8ge/edit?gid=1526789043#gid=1526789043

Transform file: https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/web_services/dot_fec/schema_fields/SchC.json

QA Notes

Verify Unit Tests

DEV Notes

null

Design

Upon completion of this ticket, note [https://fecgov.atlassian.net/browse/FECFILE-1645|https://fecgov.atlassian.net/browse/FECFILE-1645|smart-link] and [https://fecgov.atlassian.net/browse/FECFILE-1647|https://fecgov.atlassian.net/browse/FECFILE-1647|smart-link] . They need to be retested or resolved.

See full ticket and images here: FECFILE-1592

exalate-issue-sync[bot] commented 3 weeks ago

Sasha Dresden commented: Passing unit tests: [https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4308/workflows/30a5cc5b-126d-4ceb-9348-b4cf2bf062bf/jobs/12696/parallel-runs/0/steps/0-109|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4308/workflows/30a5cc5b-126d-4ceb-9348-b4cf2bf062bf/jobs/12696/parallel-runs/0/steps/0-109]

exalate-issue-sync[bot] commented 3 weeks ago

Shelly Wise commented: [~accountid:627ebeb2236090006f61d37d] [~accountid:61b0b42cc510bc006b5c03ed]please add unit test passing for coverage of the Form 3X row for all fields in the spec Thanks

exalate-issue-sync[bot] commented 3 weeks ago

Sasha Dresden commented: Passing tests:

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4315/workflows/1354313d-0e46-47dc-b95d-420407fcef10/jobs/12710/parallel-runs/0/steps/0-109|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4315/workflows/1354313d-0e46-47dc-b95d-420407fcef10/jobs/12710/parallel-runs/0/steps/0-109]

exalate-issue-sync[bot] commented 3 weeks ago

Shelly Wise commented: QA review verified unit tests passing per DEV for this ticket.

!image-20241009-120646.png|width=1422,height=820,alt="image-20241009-120646.png"!

QA Review Completed. Moved to Stage Ready.

exalate-issue-sync[bot] commented 1 week ago

akhorsand commented: Sprint conditionally accepted by Paul on 10/22/24 on the condition that we complete the hotfix FECFILE-1623. Tickets have been moved to DONE out of STAGE READY to facilitate QA processes, but full acceptance will come with the deployment of 1623.