search

fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Review and confirm unit test coverage for Schedule C1 in .fec #1070

Open exalate-issue-sync[bot] opened 1 month ago

exalate-issue-sync[bot] commented 1 month ago

As the functionality of the site has increased and changed, the validity of the creation of the Schedule C1 row of the *.fec file should be confirmed.

The task of this ticket is to check and expand the *.fec file unit test coverage of the Schedule C1 for all fields in the spec.

Spec: https://docs.google.com/spreadsheets/d/153u1rGx9FBijnANX_2KMh3iBppVVK8ge/edit?gid=282670881#gid=282670881

Transform file: https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/web_services/dot_fec/schema_fields/SchC1.json

QA Notes

Fields can be verified by viewing the Print Preview.

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1593

exalate-issue-sync[bot] commented 1 week ago

Sasha Dresden commented: Double checking validate schema against spec

exalate-issue-sync[bot] commented 1 week ago

Sasha Dresden commented: Double checked validate schema and it seemed to match the spec.

exalate-issue-sync[bot] commented 5 days ago

Elaine Krauss commented: For QA: Passing unit tests can be found [here|https://circleci.com/gh/fecgov/fecfile-web-api/12817]

exalate-issue-sync[bot] commented 2 days ago

Shelly Wise commented: QA review verified, per DEV, Unit Tests passing for this ticket.

!image-20241028-121709.png|width=1238,height=742,alt="image-20241028-121709.png"!

QA Review Completed. Moved to Stage Ready.