Open exalate-issue-sync[bot] opened 1 month ago
Sasha Dresden commented: Double checking validate schema against spec
Sasha Dresden commented: There were some missing col seq from the spec. Validate PR: https://github.com/fecgov/fecfile-validate/pull/326 API PR: https://github.com/fecgov/fecfile-web-api/pull/1131
David Heitzer commented: unit tests passing [https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4445/workflows/752b1c08-81e8-4e59-80a9-a48b338a80ea/jobs/12926|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4445/workflows/752b1c08-81e8-4e59-80a9-a48b338a80ea/jobs/12926]
!image-20241028-152551.png|width=1527,height=575,alt="image-20241028-152551.png"!
Shelly Wise commented: QA review verified, per DEV unit tests passing for this ticket.
!image-20241028-154701.png|width=1233,height=670,alt="image-20241028-154701.png"!
QA Review Completed. Moved to Stage Ready.
As the functionality of the site has increased and changed, the validity of the creation of the Schedule C row of the *.fec file should be confirmed.
The task of this ticket is to check and expand the *.fec file unit test coverage of the Schedule C for all fields in the spec.
Spec: https://docs.google.com/spreadsheets/d/153u1rGx9FBijnANX_2KMh3iBppVVK8ge/edit?gid=1936869719#gid=1936869719
Transform file: https://github.com/fecgov/fecfile-web-api/blob/develop/django-backend/fecfiler/web_services/dot_fec/schema_fields/SchC2.json
QA Notes
Fields can be verified by viewing the Print Preview.
DEV Notes
null
Design
null
See full ticket and images here: FECFILE-1594