fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

[Snyk] Investigate and resolve possible Open Redirect vulnerabilities #1170

Open exalate-issue-sync[bot] opened 3 weeks ago

exalate-issue-sync[bot] commented 3 weeks ago

Snyk has identified 4 possible “Open Redirect” vulnerabilities. We need to investigate them and, if necessary, make code changes to resolve the potential issues.

image-20241104-213252.png

image-20241104-213313.png

image-20241104-213338.png

image-20241104-213357.png

QA Notes

No code changes

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1753

exalate-issue-sync[bot] commented 3 weeks ago

Elaine Krauss commented: These “potential vulnerabilities” were found to be non-threatening. We are not redirecting with un-sanitized user input.

exalate-issue-sync[bot] commented 3 weeks ago

Elaine Krauss commented: Warnings have been marked as “Ignored” on Snyk. No code changes have been made.

exalate-issue-sync[bot] commented 2 weeks ago

Todd Lees commented: The mock endpoints are redirecting to user defined urls, but they are only used locally and in circle.

The real oidc endpoints route to system defined urls

exalate-issue-sync[bot] commented 2 weeks ago

Todd Lees commented: Passes CR moving to QA

exalate-issue-sync[bot] commented 2 weeks ago

Todd Lees commented: Ticket required no changes to code

exalate-issue-sync[bot] commented 2 weeks ago

Shelly Wise commented: Per DEV no code review changes to this ticket. No QA Review needed.

Moved to Stage Ready.