fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Report Memo schema is added to .FEC #119

Closed AureliaKhorsand closed 1 year ago

AureliaKhorsand commented 2 years ago

As a user, when I upload my report to webprint or submit my report for filing, any report level memo that I added to the report will be included in the .fec file sent. We already save report level memos in the database. This ticket simply means that we need to write the report level memo to a line at the end of the .fec file..

Task: add report memo to .fec file when everything else is added

Dev Notes

schema for report level memo: https://github.com/fecgov/fecfile-validate/blob/develop/schema/Text.json

This should just be a matter of composing and serializing in the dot_fec_composer.py

QA Notes

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-325

AureliaKhorsand commented 2 years ago

@mjtravers @toddlees can you flesh out this ticket so we can get it through the pipeline? Probably want to get this handled relatively early in OP2.

mjtravers commented 1 year ago

Passes CR. Sending to QA.

WiseQA commented 1 year ago

QA review verified creating a Report Memo and saving Report Memo is added to last line of .fec (see below screenshot).

image.png

QA Review Completed. Moved to Stage Ready.