search

fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Update .fec file submission status messages #571

Open mjtravers opened 1 year ago

mjtravers commented 1 year ago

The backend is sending submission status messages that do not reflect the state of the submission.

There are 2 situations in the period of time during the submission of a .fec file that is not being properly represented by the messages being sent back to the user

  1. A state of failure in the backend service of fecfile online after the user submits the .fec file but before the .fec file is sent to the FEC submission API.
  2. A state where the backend service of fecfile online is taking a long time to process but before the .fec file is sent to the FEC submission API.

Testing will be done by manual updates to the database.

The fecfile online backend should be updated to send to the front-end an clear and appropriate message for each of these 2 states.

DEV NOTES The code to update is in the reports app view in the get_status_mapping() function. Any error messages thrown by a backend exception should be recorded in the fecfile_error column of the upload_submissions database table.

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-263

AureliaKhorsand commented 7 months ago

@mjtravers will this have anything to do with the submission errors the users will see on the front end when we implement that?

mjtravers commented 7 months ago

@AureliaKhorsand Yes, but these are situations where things go wrong on our side and not error codes we could possibly receive from the EFO service when we submit a .fec file. We need to incorporate errors from our system into the message process that we will be setting up to convert error codes/messages we get from EFO into user-friendly messages we show to the user.

GreggMoreland commented 5 months ago

@AureliaKhorsand should this ticket be added to the submission error ticket group? This is something I think we need to include. Currently, the user will get either a Submission Pending or a Submission Failure and no EFO generated messages.

exalate-issue-sync[bot] commented 5 months ago

Aurelia Khorsand commented: @GreggMoreland sure - These will be part of the errors that can be generated on our end, as @mjtravers mentioned in a previous comment. Agreed.