PERFORMANCE - Implement transaction performance refactoring

fecgov / fecfile-web-api

Back-end API for FECfile application

Other

8 stars 2 forks source link

PERFORMANCE - Implement transaction performance refactoring #656

Closed mjtravers closed 5 months ago

mjtravers commented 9 months ago

Transactions performance issues noticed during testing for Loans and Debts.

This ticket is to implement in the code the findings and resolution strategies outlined in the spike research ticket 633(https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/gh/fecgov/fecfile-web-api/633)

QA Notes

See #633 for screenshots of issue.

DEV Notes

null

Design

null

FECFILE-240

toddlees commented 8 months ago

Note that findings in the spike #633 determined quantity of db queries had a significant effect on request times. Addressing this quantity is not initially in the scope of this ticket, but it could be added

toddlees commented 6 months ago

Unit tests passing: https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/3350/workflows/aafe2a84-6fcb-4074-8e10-7fa0166109d2/jobs/10238

mjtravers commented 6 months ago

Passes CR. Ready for QA. There are no front end features to test. See comment above for successful run of unit testes.

WiseQA commented 6 months ago

QA review verified per DEV unit tests passing.

Moved to Stage Ready.