search

fecgov / fecfile-web-api

Back-end API for FECfile application
Other
8 stars 2 forks source link

Fix database role errors in CircleCI database startup #66

Closed mjtravers closed 2 years ago

mjtravers commented 2 years ago

Some roles are missing in the database setup that are making the fecfile database import fail in CircleCI on web-api.

The fix is to add the roles import sql script to the CircleCI config.py job in the step: name: Load test database fixure

Here is a CircleCI job with the fail messages: https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/188/workflows/78f9e1e1-b1ec-437b-b7ee-2b0bc3ddeb05/jobs/479

See Matt for SQL file with create role statements

QA

To verify no errors are being thrown when spinning up the test database, look at the output of the "Container cimg/postgre:12.8" section of the CircleCI report page here

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-352

Elaine-Krauss-TCG commented 2 years ago

Following a swap in the database used by CircleCI, no more errors are present in the "Container" step of CircleCI's test stage.

The "Container" step is still passing with a grey dash instead of the desired green checkmark, but comments in discussion threads have suggested that this and similar behaviors are intended.

After digging through the CircleCI documentation for a bit, I have seen no sign to suggest that there is a way to change this.

mjtravers commented 2 years ago

Passes code review. Sending to QA.

WiseQA commented 2 years ago

QA verified no errors displayed in the output of "Container cimg/postgre:12.8"t see below screenshot: image.png

QA review completed. Moved to Stage Ready.