Open lbeaufort opened 6 months ago
[~accountid:557058:3e765e5c-5614-4ef8-975a-6f5202ed75a9] what is the status of this ticket? Still needed? If so, can we add some more detail to it? It’s in the pre-launch checklist.
@mjtravers I don't think any of these print statements pertain to prod-level behavior that should be replaced with logging statements, but I'd want to take a closer look.
Todd Lees commented: passes cr moving to qa https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4585/workflows/50b48a44-93ae-48bb-b39f-5a17b2a126cc/jobs/13195
Todd Lees commented:
!image-20241119-140745.png|width=980,height=596,alt="image-20241119-140745.png"!
Shelly Wise commented: QA review verified tests passing per DEV.
!image-20241119-164548.png|width=975,height=604,alt="image-20241119-164548.png"!
QA Review Completed. Moved to Stage Ready.
There are print statements in api components that should but using logging.
Convert print statements in api code into logging statements. Code that is not part of the application, like utility scripts do not need to be converted.
[https://github.com/search?q=repo%3Afecgov%2Ffecfile-web-api%20print(&type=code](https://github.com/search?q=repo%3Afecgov%2Ffecfile-web-api%20print(&type=code)
QA Notes
null
DEV Notes
null
Design
null
See full ticket and images here: FECFILE-160