Remove FILE_AS_TEST_COMMITTEE and TEST_COMMITTEE_PASSWORD settings

lbeaufort commented 1 month ago

Remove FILE_AS_TEST_COMMITTEE and TEST_COMMITTEE_PASSWORD settings

Business Reason

As a developer, I will be able to understand application configuration so that I can fix issues as they arrive.

QA Notes

null

DEV Notes

The api settings FILE_AS_TEST_COMMITTEE and TEST_COMMITTEE_PASSWORD were used prior to our setup of creating unique committees for each test user. These settings are OBE and can be removed from the code base.

Locations to remove:

[x] base settings file
[x] web_services app
[x] Docker compose file
[x] Cloud.gov credentials services in DEV
[ ] Cloud.gov credentials services in STAGE
[ ] Cloud.gov credentials services in PROD

QA Notes

To test, the ticket is successful if a user can submit a filing to Test EFO without error. Just 1 test submission is sufficient.

Design

null

FECFILE-1410

dheitzer commented 1 week ago

Tested/confirmed on local:

mjtravers commented 1 week ago

Passes CR. Sending to QA. Here are the unit tests passing: https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/3838/workflows/1cb05452-d818-430c-8120-d190ad6702f8/jobs/11567

Also, the updates to the credential will be performed in each cloud.gov space after the code has been deployed to each space. DEV credential have been updated. The checkbox for the ticket item will be checked off after STAGE and PROD have been updated after deployment.

WiseQA commented 1 week ago

QA review completed verifying DEV unit tests passing for this ticket.

QA Review Completed. Moved to Stage Ready.

fecgov / fecfile-web-api