Limit the inclusion of children in transaction payloads to double and triple transaction sets

[exalate-issue-sync[bot]]

The api currently includes the transaction ids of all the children for a transaction and the front end automatically retrieves them. This process can be streamlined as the front-end only needs to manage the child/grandchild transactions in a single save/commit for a subset of transaction_type_identifiers.

TASK

Update the API and make the related changes to the front end so that the child transactions are provided when the transactions are the following “doubles”:

• CONDUIT_EARMARK_RECEIPT
• EARMARK_RECEIPT_CONVENTION_ACCOUNT
• EARMARK_RECEIPT_HEADQUARTERS_ACCOUNT
• EARMARK_RECEIPT_RECOUNT_ACCOUNT
• EARMARK_RECEIPT
• IN_KIND_RECEIPT
• IN_KIND_TRANSFER_FEDERAL_ELECTION_ACTIVITY
• IN_KIND_TRANSFER
• LOAN_BY_COMMITTEE
• LOAN_RECEIVED_FROM_INDIVIDUAL
• PAC_CONDUIT_EARMARK
• PAC_EARMARK_RECEIPT
• PAC_IN_KIND_RECEIPT
• PARTY_IN_KIND_RECEIPT

And provide the child and grandchild transactions for the one “triple” transaction set:

• LOAN_RECEIVED_FROM_BANK

QA Notes

Test to see if a sample of the transaction types listed in the ticket description work correctly when saving multiple transactions at the same time.

DEV Notes

• Modify the transaction serializer to not provide any children data in the payload: [https://github.com/fecgov/fecfile-web-api/blob/release/sprint-44/django-backend/fecfiler/transactions/serializers.py#L161-L164|https://github.com/fecgov/fecfile-web-api/blob/release/sprint-44/django-backend/fecfiler/transactions/serializers.py#L161-L164|smart-link]
• Update the resolver in the front end to only retrieve the child transactions for the transaction types listed in the ticket description: [https://github.com/fecgov/fecfile-web-app/blob/develop/front-end/src/app/shared/resolvers/transaction.resolver.ts#L82-L95|https://github.com/fecgov/fecfile-web-app/blob/develop/front-end/src/app/shared/resolvers/transaction.resolver.ts#L82-L95|smart-link]
• Ensure the saving of child transactions in the view is still working as expected and not editing or removing child transactions for transactions that can have an unlimited number of child transactions: [https://github.com/fecgov/fecfile-web-api/blob/release/sprint-44/django-backend/fecfiler/transactions/views.py#L306-L320|https://github.com/fecgov/fecfile-web-api/blob/release/sprint-44/django-backend/fecfiler/transactions/views.py#L306-L320|smart-link]

Design

null

See full ticket and images here: FECFILE-1483

[exalate-issue-sync[bot]]

David Heitzer commented: API PR https://github.com/fecgov/fecfile-web-api/pull/1013

[exalate-issue-sync[bot]]

Passes CR. Sending to QA.

[exalate-issue-sync[bot]]

Matt Travers commented: For QA, passing unit tests:

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4091/workflows/a56c5bb4-ab1c-4582-95e6-38bbdf14e36b/jobs/12257|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4091/workflows/a56c5bb4-ab1c-4582-95e6-38bbdf14e36b/jobs/12257]

!image-20240821-200036.png|width=1611,height=539,alt="image-20240821-200036.png"! See image in Jira

[exalate-issue-sync[bot]]

Shelly Wise commented: QA review visual inspection of Unit Tests passing. (NOTE: Tested PAC_EARMARK_RECEIPT and LOAN_RECEIVED_FROM_INDIVIDUAL)

!image-20240822-142603.png|width=1250,height=417,alt="image-20240822-142603.png"! See image in Jira

QA Review Completed. Moved to Stage Ready.

[exalate-issue-sync[bot]]

Automation for Jira commented: Sprint accepted by Paul Clark at Sprint Review on comment date.