search

fecgov / fecfile-web-api

Back-end API for FECfile application
8 stars 2 forks source link

Update purpose description with dynamic text in parent transactions #991

Closed exalate-issue-sync[bot] closed 1 day ago

exalate-issue-sync[bot] commented 1 month ago

There is a set of transactions whose parent needs to be updated when the child is CREATED or DELETED. The parent’s purpose description text is dependent on whether it has children or not.

(child) → (parent)

PARTNERSHIP_ATTRIBUTION_JF_TRANSFER_MEMO → PARTNERSHIP_JF_TRANSFER_MEMO

PARTNERSHIP_ATTRIBUTION_NATIONAL_PARTY_CONVENTION_ACCOUNT_MEMO → PARTNERSHIP_NATIONAL_PARTY_CONVENTION_ACCOUNT

PARTNERSHIP_ATTRIBUTION_NATIONAL_PARTY_CONVENTION_JF_TRANSFER_MEMO → PARTNERSHIP_NATIONAL_PARTY_CONVENTION_JF_TRANSFER_MEMO

PARTNERSHIP_ATTRIBUTION_NATIONAL_PARTY_HEADQUARTERS_ACCOUNT_MEMO → PARTNERSHIP_NATIONAL_PARTY_HEADQUARTERS_ACCOUNT

PARTNERSHIP_ATTRIBUTION_NATIONAL_PARTY_HEADQUARTERS_JF_TRANSFER_MEMO → PARTNERSHIP_NATIONAL_PARTY_HEADQUARTERS_JF_TRANSFER_MEMO

PARTNERSHIP_ATTRIBUTION_NATIONAL_PARTY_RECOUNT_JF_TRANSFER_MEMO → PARTNERSHIP_NATIONAL_PARTY_RECOUNT_JF_TRANSFER_MEMO

PARTNERSHIP_ATTRIBUTION → PARTNERSHIP_RECEIPT

PARTNERSHIP_ATTRIBUTION_RECOUNT_ACCOUNT_RECEIPT_MEMO → PARTNERSHIP_RECOUNT_ACCOUNT_RECEIPT

QA Notes

The purpose description of the transaction types listed in the ticket description should have the dynamic text expected when the child transaction is updated.

Unit tests to be provided.

DEV Notes

The purpose description for the parent only needs to be updated on the child transaction CREATE or DELETE as the description text depends on whether the parent has child transactions or not.

Get rid of {{getUpdatedParent}} on App since this Api change will accomplish what that method sets out do do

Design

null

See full ticket and images here: FECFILE-1502

exalate-issue-sync[bot] commented 3 weeks ago

app pr: https://github.com/fecgov/fecfile-web-app/pull/2115

exalate-issue-sync[bot] commented 3 weeks ago

Passes CR. Sending to QA.

exalate-issue-sync[bot] commented 3 weeks ago

Matt Travers commented: For QA: unit tests passing

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4079/workflows/9c756617-be74-4fea-a979-a4bc4bdea529/jobs/12223|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4079/workflows/9c756617-be74-4fea-a979-a4bc4bdea529/jobs/12223]

!image-20240821-190102.png|width=1611,height=539,alt="image-20240821-190102.png"! See image in Jira

exalate-issue-sync[bot] commented 3 weeks ago

Shelly Wise commented: QA review verified the Unit Test passes.

!image-20240821-190241.png|width=1283,height=410,alt="image-20240821-190241.png"! See image in Jira

QA Review Completed. Moved to Stage Ready.

exalate-issue-sync[bot] commented 1 day ago

Automation for Jira commented: Sprint accepted by Paul Clark at Sprint Review on comment date.