fecgov / fecfile-web-app

Other
7 stars 4 forks source link

Allow user to enter Independent Expenditure - Void on Schedule E #1117

Closed GreggMoreland closed 12 months ago

GreggMoreland commented 1 year ago

Business Reason

As a Committee Administrator, I will be able to enter a ”Independent Expenditure - Void" transaction on Schedule E of a Form 3X report so that I can accurately report on my committee's transactions.

Acceptance Criteria

Given I am a Committee Administrator editing an open Form 3X report

Then go to Add a disbursement

Then I can enter a transaction with the type “Independent Expenditure - Void" under the "Independent Expenditures" Accordion link

Then I will be required to enter the following information (unless otherwise noted):

Payee

#

if CONTACT TYPE = Organization

if CONTACT TYPE = Individual

  1. Address

    #

  1. Expenditure information

    #

  1. Candidate information

    #

  1. Election information

    #

  1. Additional information

    #

  1. Committee treasurer

    #

Then I will be able to:

And if the Aggregate amount is >= $200.01,

Then the transaction will be itemized upon saving and saved with it's own line item on the *.fec file on line SE.

If the Aggregate amount is [x] Update schema to match Spec Updates spreadsheet tab here This is a consolidated specification

Wireframes

  1. IE Void Inital load with Candidate info collapsed Private Zenhub Image

  2. IE Void Fully expanded Private Zenhub Image

  3. Expenditure info error Private Zenhub Image

  4. Candidate info error Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

QA Notes

null

DEV Notes

null

Design

mary-tcg commented 1 year ago

@AureliaKhorsand @GreggMoreland @MitchellTCG wire added

AureliaKhorsand commented 1 year ago

@MitchellTCG @mary-tcg can we show the Candidate information collapsed in a wire, then expanded in the other with the data filled in? Also, a wire showing the validation error if the Candidate information is not entered (should look the same as #1164).

We also need the error message similar to #294 to apply for the dates. It's odd, because if one date is present, that error applies, but if both are present, it only applies to Disbursement date.

MitchellTCG commented 1 year ago

@GreggMoreland Wires posted and UX review complete please note that Support and Oppose radio buttons are unselected upon initial load but a choice is required

MitchellTCG commented 1 year ago

Wires are updated

mjtravers commented 1 year ago

@WiseQA Until ticket #1386 is done, the CALENDAR YEAR-TO_DATE value will simply match the AMOUNT value.

mjtravers commented 1 year ago

Passes CR. Sending to QA.

WiseQA commented 1 year ago

QA review verified when selecting "Add a disbursement" then under "Independent Expenditures" select 'Independent Expenditure - Void" transaction page is displayed.

Private Zenhub Image

Verified LOOKUP is defaulted to Organization.

Private Zenhub Image

Verified Independent Expenditure - Void transaction page is displayed.

Private Zenhub Image

Verified Amount when entered is a negative number

Private Zenhub Image

Verified Amount field and Calendar Year-To-Date fields are populated with amount. Calendar Year-To-Date is read-only field. (Note: Actual functionality in ticket 1386)

Private Zenhub Image

Verified entering Dissemination Date outside report coverage dates the "Just checking ... " popup window is displayed. Memo Item becomes a required field.

Private Zenhub Image

Verified entering Disbursement Date outside report coverage dates the "Just checking ... " popup window is displayed. Memo Item becomes a required field.

Private Zenhub Image

Verified error message displayed "At least ONE date field must be entered"

Private Zenhub Image

Verified Candidate information error message displayed "An answer is required"

Private Zenhub Image

QA review verified the transactions table to display date column as currently designed. The Disbursement Date field will be populated in the date column of the transactions table only at this point. (NOTE: Future clarification with FEC to determine if the Dissemination Date field will populate in the date field if Disbursement date is NOT filled in in the transaction)

Line number 24 has been added to the transactions table for the Independent Expenditure - Void disbursement transaction.

WiseQA commented 1 year ago

QA review retested transaction and verified transactions action table is being updated correctly (by current design / requirement). Line 24 verified added for Independent Expenditure - Void disbursement transaction.

Private Zenhub Image

QA Review Completed. Moved to Stage Ready.

WiseQA commented 12 months ago

Ticket placed on-hold as a DEFECT #1456 was found during Sprint 32 demo. DEFECT #1456 PASSES.

Private Zenhub Image

@MitchellTCG IE Transactions have been retested and validated as Passing for Sprint 32. Removed on-hold and closed.