fecgov / fecfile-web-app

Other
7 stars 4 forks source link

Allow user to submit Form 24 report #1338

Closed GreggMoreland closed 9 months ago

GreggMoreland commented 1 year ago

Business Reason

As a user, I will be able to submit a completed Form 24 report so that I can generate a *.fec file and send it to the FEC.

Acceptance Criteria

Given a Form 24 Report Then there will be the pages "Confirm information" and "Submit report" under the SIGN & SUBMIT section of left-hand navigation

and when a user is on the "Confirm information" page, they will enter the following information:

And when a user is on the "Submit report" page, they will enter the following information:

Treasurer Information

DEV NOTES

Let's refactor the submit-f3x-step1 (call it submit-confirm-info), submit-f3x-step2 (call it submit-report), and submit-f3x-status (call it submit-status) components into a new reports/shared directory. Each component will have it's own directory in the reports/shared directory.

UX Comment

We will not change the general look and feel. No new grey box. we will add in illustration instead of old fan of 5 pages

Wireframes

Confirm Information

Private Zenhub Image

Submit report

Private Zenhub Image

Congratulations

Private Zenhub Image

Processing

Private Zenhub Image Report status

QA Notes

Then they will be required to check the box with the following text before being able to submit:

I certify that I have examined this Statement and to the best of my knowledge and belief it is true, correct, and complete. NOTE: Submission of false, erroneous, or incomplete information may subject the person signing this Statement to the penalties of 52 U.S.C. § 30109.

And when the user clicks "Submit", they will receive a confirmation popup with the following language:

Are you sure you want to submit this form electronically? Please note that you cannot undo this action. Any changes needed will need to be filed as an amended report.

And when the user confirms submission

QA Notes

MitchellTCG commented 11 months ago

@GreggMoreland Please review

GreggMoreland commented 11 months ago

@MitchellTCG something I think I missed on the 99 and 1M, but shouldn't 'Submit Report' in the left NAV be 'Submit report'?

MitchellTCG commented 11 months ago

@GreggMoreland Good catch (painful to update but good catch)

I reposted above

MitchellTCG commented 11 months ago

@GreggMoreland Report status pages added

MitchellTCG commented 10 months ago

Same EFO issue as 1339

mjtravers commented 10 months ago

An issue was found in the Sch E JSON schema in the property order that was causing the submit to fail. The schema has been corrected.

Passes CR. Sending to QA.

WiseQA commented 10 months ago

QA review tested submission of Report Form 24. Select Form 24 from Manage reports page.

Verified once Selected Confirm information under “SIGN & SUBMIT” in the left NAV bar. Verified Email is correct then select “Confirm information” button

image.png

Verified committee treasure first name / last name is populated correctly. Enter ELECTRONIC FILING PASSWORD (NOTE: Password deliberately not shown). Select checkbox for “I certify . . . Then select “Submit: button

image.png

@MitchellTCG popup window "Are you sure ? is not in the above wireframe(s). Is the popup the same as Form 3x (amend a report?) or the same as Form 99? Please verify correct verbiage.

image.png
MitchellTCG commented 10 months ago

Form 24 will use the same pop up as the one used on form 3x

WiseQA commented 10 months ago

QA verified pop is displayed (same as Form 3x )

image.png

Verified "Report status" page is displayed. Thanks for submitting your report - Report Type - Form 24

image.png

Verified "Manage reports" table updated to reflect Form 24 - Submission Success. This failed - Submission Failure. Email receipt worked.

image.png

Below screenshot of why Submission Failed.

image.png

@mjtravers @MitchellTCG placing ticket On-Hold for Submission failure reasoning above. After review with @toddlees the URL is incorrect coming back from efo. Should be the testefoservices URL but it is coming back as see below screenshot:

image.png

@mjtravers reaching out to Mahi.

WiseQA commented 10 months ago

@mjtravers @MitchellTCG retested after Mahi corrected url to testefoservices. However, as discussed getting this validation error for "House" committee ID being submitted using our format "HX XXXXX" Below screenshot of submission failure with Web Check validation of error.

image.png
toddlees commented 10 months ago

@MitchellTCG @mjtravers @WiseQA @AureliaKhorsand @GreggMoreland It appears that their webcheck is stricter than the requirements they've given us. There is no state with the code PP. I suspect that if you change that PP to MD or any other state code, it will be valid. We've never been told that the 3rd and 4th characters need to be validated as an actual state code

WiseQA commented 10 months ago

@mjtravers @MitchellTCG I created a Form 24 for Candidate Information using: House "H1PP87654" and a Senate "S6GG87654" they both failed when submitting Form 24. Created Form 24 for Candidate Information used Presidential "P56545678" and the Form 24 submitted successfully.

The submission errors are not recognizing Candidate IDs for House using our format "HX XXXXX" nor senate using our format "SX XXXXX"

image.png

Below is screenshot of when using Presidential - Form 24 submitted correctly.

image.png

@mjtravers also the rejected emails (when using House and Senate) shows the following: URL is not the test efo

image.png
WiseQA commented 10 months ago

@mjtravers @MitchellTCG I entered the abbreviation "VA" for Virginia and tried submitting again, still got the submission failure

image.png image.png
WiseQA commented 10 months ago

QA review with DEV, Form 24 report submits correctly using the following scenario for submission. (NOTE: Use Login.gov test committee ID)


  1. Form 24 must be itemized.
image.png
  1. Lookup is actual candidate pulled from FEC (NOTE: Committee ID has the abbreviation of State for candidate)
image.png
  1. Committee treasure Last Name / First Name entered that is associated with TEST COMMITTEE ID
image.png
  1. Verified Form 24 Submission Successful (using above scenario)
image.png
  1. Received email notification filing was received and accepted.
image.png
  1. Webcheck validation
image.png
  1. Submission displayed correctly on the FEC Electronic Filings
image.png

@mjtravers @MitchellTCG this ticket passes using the above scenario. During testing with DEV, there are data validations that need to be reviewed for submission of forms. API ticket made to document data validations needing reviewed.