Open WiseQA opened 11 months ago
This error cannot be reproduced on local or DEV, but the way things are currently designed does raise certain questions. Currently, Report Codes are greyed out when another report exists with that exact same Report Code. Already having a Q1 Report does not grey out the M1 or M2 Report Codes. Report Codes are also not greyed out when another report's coverage dates overlaps with the default dates of that Report Code. Do we want to change either of these behaviors?
@MitchellTCG the way the greying is working is to grey out codes that you used this year based on https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/gh/fecgov/fecfile-web-app/361. Since there is no way for the user to say what year they want to make a report for, "within calendar year" could only be interpreted as the present year as the user interacts with the form.
So in Shelly's scenario above, she has reports using those codes in 2020, but since she was interacting with it in 2023, nothing was greyed out because there are no m2s or m3s "within the calendar year".
@MitchellTCG @toddlees any memory as to why this is on hold? What is the status of this?
@MitchellTCG why is this on hold?
Also, can we make sure we're allowing for users to make reports for the next calendar year? For example, if they want to make an M1 report for the next year in December, we should let them do that,
Mitchell Jarrett commented: [~accountid:61b0b42cd5986c006a9e1c94] I placed this on hold so I can talk to Todd and Jonella about a fix
UX needs to review this workflow
During QA and DEV testing when creating a new Monthly Report the previous months are not being greyed out under the report type for that covering period. Used year xx/xx/2020 From / To dates (Tested using login.gov and Stage) (Tested on both Stage and DEV environments)
Below screenshot shows M2 and M3 report created for xx/xx/2020
[!image-20240531-134815.png!| /attachments/11322?name=image-20240531-134815.png]
See image in Jira
Below screenshot of monthly reporting report type not being greyed out once created.
[!image-20240531-134851.png!| /attachments/11321?name=image-20240531-134851.png]
@MitchellTCG @mjtravers fix the Report type should be greyed out for Monthly reporting for both Election and Non-election year once generated. Bug fix 3pts and assigned to Sprint 34.
/
QA Notes
null
DEV Notes
null
Design
null
See full ticket and images here: FECFILE-562