search

fecgov / fecfile-web-app

Other
7 stars 4 forks source link

System to keep aggregates separate by report type #1580

Open AureliaKhorsand opened 9 months ago

AureliaKhorsand commented 9 months ago

Business Reason

System should ensure that aggregates are calculated only within the same report type (e.g., Form 3X transactions are aggregated with Form 3X transactions, but NOT Form 3 transactions) to prevent double counting.

Acceptance Criteria

Given an aggregated transaction When the transaction is saved Then the aggregate will ONLY be calculated within the same report type.

QA Notes

DEV Notes

null

Design

null

AureliaKhorsand commented 9 months ago

@toddlees we briefly referenced this recently - can you or @mjtravers comment on current system functionality? I am assuming that aggregates are calculated by entity (or per election office sought) and aggregate group, but there are no guard rails on report type. Is that right?

mjtravers commented 9 months ago

@AureliaKhorsand Yes, that's correct. The aggregate value for a primary contact includes all transactions that the contact is associated with as the primary without taking into consideration the report type.

toddlees commented 8 months ago

@AureliaKhorsand @mjtravers I'm not sure this ticket is relevant any longer given that a transaction on F24 is the same record as that transaction on the F3X.

AureliaKhorsand commented 7 months ago

Confirmed with dev team that this ticket is still relevant as this is a universal rule for all reports (see requirements notes on 12/19/23).

AureliaKhorsand commented 7 months ago

On hold per Ryan's concerns on Slack. Needs further discussions with Ryan.

MitchellTCG commented 6 months ago

@AureliaKhorsand I moved this back to AA until a decision is made re: Ryan's comments

GreggMoreland commented 6 months ago

@AureliaKhorsand where might I find Ryan's comments? @mjtravers @toddlees this ticket will likely be needed once we start on the other reports (3, 3P) which calculate aggregates based on election cycle, not on calendar year....so an individual aggregate for 3x would be different than the aggregate for 3. Any thoughts or comments on this?

toddlees commented 6 months ago

@GreggMoreland @AureliaKhorsand @mjtravers agreed, the entity aggregates over an election cycle will have to be handled independently. I'm still surprised by the comment in the 12/19/23 meeting:

Aggregates carry over from report to report, but do not get combined between report types (e.g., between Form 3X and Form 3).

Certainly entity aggregates over and election period (form 3) and calendar year (form 3x) would be calculated separately; they are over different windows of time. However, I'm having trouble understanding why we would not want the dollar amount of a transaction in an f3x to factor in to the entity election-cycle aggregate of an f3.

Edit: I guess what I'm wondering is this statement to be interpreted as the aggregates don't interact (i wholeheartedly agree) o r that the transactions are not referenced across report types (i have suspicions about this approach)

AureliaKhorsand commented 6 months ago

This has been confirmed as NOT NEEDED for test release 1, since this won't be relevant until we have additional report types. This ticket also needs more clarification from FEC on how aggregates will work if a committee changes type and has reports that track aggregates differently. Moving to Product Backlog until a later date.