Allow user to enter Cash-on-Hand (6a) for first report in FECFile Online

AureliaKhorsand commented 2 years ago

Business Reason

As a user, I will be able to enter Cash-on-Hand manually in my first report on FECFile Online so that the system can auto-calculate it in subsequent reports.

Acceptance Criteria

QA Notes

The COH left nav menu item will only be visible when the first report for a Committee Account is visible. Work with devs to clear out reports before testing. The "create new report" button on the report list page will be disabled after the first report is created and stay disabled until a cash on hand amount and date are saved for the report. The user can then create new reports but the COH screen and menu item will only display for that initial report.

DEV Notes

null

Design

If a Committee Account has never before filed a report in FECFile Online When the user creates their Form 3X report Then they will have the option to:

enter Cash-on-Hand (AMT-12, which will be 9 digits .(dot) 2 digits, currency format) OR;
"Skip for now" and move on to Manage Transactions, OR;
Cancel and go back to Manage Reports

And if they enter a currency value for Cash-on-Hand, they will be required to enter a date for that amount And they will be unable to submit a report or create another report in the Committee Account until they enter Cash-on-Hand and a date in their first report ($0.00 is an acceptable amount, for example a new committee)

If they have not entered COH, there will be a message on the Submit Report page indicating they must enter COH before submitting.

Dev and Design Notes:

The number must be in currency format, and should not accept negative values.
This will be for Form 3X Line 6a in the *.fec file as well.
Specs indicate AMT-12, which will be 9 digits .(dot) 2 digits
This is ONLY editable on the very first report in FECFile Online or an amendment of that first report. This will not be editable in any subsequent report.

COH 1.png

COH 2.png

See full ticket and images here: FECFILE-1246

AureliaKhorsand commented 2 years ago

BA Notes from 4/7/22 requirements meeting:

This should be no more than 12 numbers.
This will have to be manual entry the first time someone uses FECFile Online.
Once there are previous reports in the system, any new report should pull forward and auto-populate Cash-on-Hand. There should always be an option to edit, however.

AureliaKhorsand commented 2 years ago

BA Notes:

See requirements notes from 6/2/2022 for more information.
Line 8 will auto-populate, as well all subsequent reports. This is the only time a user enters Cash-on-Hand manually.

AureliaKhorsand commented 2 years ago

BA Note: Need to discuss Cash on hand - if totally new, wouldn't it be $0 $0 for every 6a and 6b?

AureliaKhorsand commented 2 years ago

Per Ryan on Slack 7/8/22: I think it is something they could do when they create their first report. With that said, I don't know if I support pushing it on them. FECfile desktop doesn't make it a first or second step, and I am reluctant that we make it too prominent. In regards to your second question, the committee should have the ability to edit it after it was first entered. Theoretically, they should have the ability to edit it even after their first report is submitted, but that should trigger the report to be amended.

MitchellTCG commented 2 years ago

@AureliaKhorsand Let me know if this works for you

AureliaKhorsand commented 2 years ago

@MitchellTCG several things:

User should be able to indicate that they are a new committee, thus it will be $0.00
User needs to be able to enter a date
User will need to be able to go back and edit this at any time before the first report is submitted
Looks like the informational text isn't quite finished

The ACs should have all of this for reference

mjtravers commented 2 years ago

Passed CR by Elaine and Todd. Sending to QA

mjtravers commented 2 years ago

There are questions about how the COH workflow will happen when the user opens 2 new reports without entering a value for COH. Moving ticket back to In Progress until this is sorted out

AureliaKhorsand commented 2 years ago

@MitchellTCG temporary workaround we came up with is that users cannot create additional reports until the COH is entered for the first report. This is a temporary solution - we need to come up with a more user friendly COH process overall in OP2.

MitchellTCG commented 2 years ago

ok

On Wed, Aug 10, 2022 at 11:07 AM AureliaKhorsand @.***> wrote:

@MitchellTCG https://github.com/MitchellTCG temporary workaround we came up with is that users cannot create additional reports until the COH is entered for the first report. This is a temporary solution - we need to come up with a more user friendly COH process overall in OP2.

— Reply to this email directly, view it on GitHub https://github.com/fecgov/fecfile-web-app/issues/196#issuecomment-1210809862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDHDVTKLYJCCEMFK6ZGU7DVYPAU5ANCNFSM5SJAKOEQ . You are receiving this because you were mentioned.Message ID: @.***>

-- H. Mitchell Jarrett, A-CSM, CSM, CSPO Agile Project Manager TCG, Inc. - Positively Distinct - CMMI-DEV Level 3 - CMMI-SVC Level 2 - ISO 9001:2008 Tel: 202.395.2462 | Mobile: 202.270.1935 | @.*** | www.tcg.com https://www.facebook.com/TCG-32241785903 https://twitter.com/TCGnews [image: Linkedin] https://www.linkedin.com/in/mitchell-jarrett-4610096

WiseQA commented 2 years ago

@mjtravers per our conversation this morning on Cash On Hand and testing and this ticket returned to in-progress for clarification. The above mentioned workaround is what will be tested, please update QA notes as we talked. Thanks

mjtravers commented 2 years ago

Discussed changes have been made and a description of the behavior is in the QA notes. Passes CR. Sending to QA.

toddlees commented 2 years ago

WiseQA commented 2 years ago

QA review with DEV for Cash On Hand. Verified works as denoted in ticket.

Select Cash On Hand from the Left Navigation
Enter 12 digit dollar amount:
Enter Negative dollar amount - receive error:
Enter 13 digits receive error:
"Create a new report" button is disabled until Cash On Hand is saved for first report.
Verify on Submit Page verbage appears "You may not submit ......." message is displayed.

Save and Continue
"Create a new report" button is selectable
Select Submit Page - enter required fields (Note: Cash on Hand has been saved". Click Submit button, report is filed.

QA Review Completed by demo with DEV. Moved to Stage Ready.

fecgov / fecfile-web-app