fecgov / fecfile-web-app

Other
7 stars 4 forks source link

Allow user to "un-amend" a report #2018

Closed exalate-issue-sync[bot] closed 3 weeks ago

exalate-issue-sync[bot] commented 3 months ago

As a user, I will have the ability to ‘un-amend’ a report (currently Form 3x and Form 24s - 24 HOUR REPORT OF INDEPENDENT EXPENDITURES and 48 HOUR REPORT OF INDEPENDENT EXPENDITURES) that is marked with ‘In progress’ status, so that I can manage my reports.

Acceptance Criteria

Given I am on the “Manage reports” page

When I have a report listed as an Amendment in ‘In progress’ status

And the report has not had any transactions added to it or updated since it was last submitted

Then I will be able to ‘un-amend’ the report

And the system will re-set the Status and Type to the previous values (before it was set to Amendment status)

And the user will see a success message.

QA Notes

See dev notes for examples.

DEV Notes

Design

h1. Wireframes

h3. Step 1: View Manage reports page (looking at Amendment 1)

!Screenshot 2024-08-14 at 10.18.13 AM.png|width=2133,height=1788,alt="Screenshot 2024-08-14 at 10.18.13 AM.png"!

h3. Step 2: Unamend Amendment 1 (only if nothing has changed in the amendment - this will be programmatic)

!Screenshot 2024-08-14 at 10.18.18 AM.png|width=2133,height=1788,alt="Screenshot 2024-08-14 at 10.18.18 AM.png"!

h3. Step 3: After the Unamend function is complete, the transaction will revert to the prior version, Original in this case, and the prior status, Submission success. The dropdown will now show the Amend option instead of Unamend.

h3. DEVs please be aware a Toast should appear to let the user know the reversion process was a success.

!Screenshot 2024-08-14 at 10.03.44 AM.png|width=1875,height=1652,alt="Screenshot 2024-08-14 at 10.03.44 AM.png"!

See full ticket and images here: FECFILE-1444

exalate-issue-sync[bot] commented 2 months ago

gregg.moreland commented: [~accountid:61b0b42cd5986c006a9e1c94] since this was mentioned during the demo, I took an initial stab at the requirements here

exalate-issue-sync[bot] commented 1 month ago

Mitchell Jarrett commented: [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] [~accountid:61b0b42cd5986c006a9e1c94] [~accountid:5b93ddba73130a2b8c662e23]

PLS review

exalate-issue-sync[bot] commented 1 month ago

passes CR moving to QA

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: QA review for Form 3x report:

Select a Form 3x Quarterly Report ”in-progress” state and submit report to Amendment 1.

Select Form 3x Quarterly Report Amendment 1 and submit report (NOTE: Nothing was changed or added to this report - see notes from UX above)

!image-20240826-162016.png|width=926,height=356,alt="image-20240826-162016.png"! See image in Jira

Select the Actions kabob to unamend the report. (This is the issue of not working)

QA review for Form 24 report:

Select a Form 24 - 48 hour report ”in-progress” state and submit report to Amendment 1.

!image-20240826-162820.png|width=996,height=230,alt="image-20240826-162820.png"!

!image-20240826-192536.png|width=1348,height=217,alt="image-20240826-192536.png"!

Select Form 24 - 48 hour report Amendment 1 and submit report (NOTE: Nothing was changed or added to this report - see notes from UX above)

Select the Actions kabob to unamend the report. (This is the issue of not working)

NOTE: Form 24 - 48 hour report having submission issues also

[~accountid:557058:3e765e5c-5614-4ef8-975a-6f5202ed75a9] [~accountid:627ebeb2236090006f61d37d] moving back to In-progress for these fixes.

exalate-issue-sync[bot] commented 1 month ago

Per discussion with [~accountid:61b0b42cd5986c006a9e1c94] changed the description of this ticket to add Form 3x and both Form 24 reports.

exalate-issue-sync[bot] commented 1 month ago

Patch made to environment variables on DEV. Ready for QA again.

Passes CR. Sending to QA.

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: QA review retested after DEV patch a Form 24 report:

Select a Form 24 - 24 hour report ”in-progress” state and submit report to Amendment 2. Per UX do not change anything within the report.

!image-20240827-172230.png|width=1247,height=137,alt="image-20240827-172230.png"! See image in Jira

Select the Actions Kabob dropdown menu then select Unamend.

The Form 24 - 24 hour report ”in-progress” state and submit report goes back to Amendment 1.

QA review retested after DEV patch Form 3x report:

Select a Form 3x ”Submission success” state version Amendment 1. Select Amend from the dropdown menu the version becomes “In-progress” state version

Select “Unamend” from the dropdown

!image-20240827-173701.png|width=1292,height=156,alt="image-20240827-173701.png"!

Verify ”Submission success” state version Amendment 1 is now displayed.

!image-20240827-173828.png|width=1267,height=114,alt="image-20240827-173828.png"!

QA Review Completed. Moved to Stage Ready.

exalate-issue-sync[bot] commented 3 weeks ago

Automation for Jira commented: Sprint accepted by Paul Clark at Sprint Review on comment date.