UI: Update Form 24 TYPE and COVERAGE on "Manage reports" Data Table

exalate-issue-sync[bot] commented 1 month ago

Issue:

Currently TYPE and COVERAGE are not displaying for the Form 24 on the Manage reports data table, nor is the sub-label appearing on the “Transactions in this report” page within the report.

Tasks:

The TYPE should read one of the following, dependent on if the user selected 24 or 48 hour upon Form 24 report creation:
24 HOUR REPORT OF INDEPENDENT EXPENDITURES or
48 HOUR REPORT OF INDEPENDENT EXPENDITURES
The COVERAGE should read: N/A
The sub-label on the “Transactions in this report” page within the report should match TYPE.

QA Notes

null

DEV Notes

null

Design

h2. Wireframes

h4. Current State:

!Screenshot 2024-07-10 at 5.01.12 PM.png|width=1057,height=913,alt="Screenshot 2024-07-10 at 5.01.12 PM.png"!

Ideal State:

!Screenshot 2024-07-10 at 6.39.25 PM.png|width=1271,height=975,alt="Screenshot 2024-07-10 at 6.39.25 PM.png"!

Where the user selects 24 or 48 hour report upon Form 24 report creation:

!image-20240711-135344.png|width=611,height=363,alt="image-20240711-135344.png"! See image in Jira

“Transactions in this report” page should include type after “Form 24” :

!image-20240725-135358.png|width=622,height=243,alt="image-20240725-135358.png"!

FECFILE-1466

exalate-issue-sync[bot] commented 1 month ago

Mitchell Jarrett commented: [~accountid:61b0b42cd5986c006a9e1c94] pls review

exalate-issue-sync[bot] commented 1 month ago

Sasha Dresden commented: Quick question on this. Should the sub label also update? This is seen on the Transaction List for a report. It currently says:

!image-20240724-204423.png|width=448,height=83,alt="image-20240724-204423.png"!

But I was wondering if it should instead say:

!image-20240724-204405.png|width=465,height=84,alt="image-20240724-204405.png"!

I can go either way on this, but noticed that for all of the other reports, what shows up as the type here matches (or will match after the recent tickets) the label on the Transaction list.

exalate-issue-sync[bot] commented 1 month ago

akhorsand commented: [~accountid:627ebeb2236090006f61d37d] ticket updated to include updating the sub-label. Great catch!

exalate-issue-sync[bot] commented 1 month ago

Sasha Dresden commented: 2 Code reivews: APP PR API PR

exalate-issue-sync[bot] commented 1 month ago

Matt Travers commented: Passes CR. Sending to QA.

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: QA review verified for Form 24 for selected 24 or 48 hour under “Type”

24 HOUR REPORT OF INDEPENDENT EXPENDITURES
48 HOUR REPORT OF INDEPENDENT EXPENDITURES

Verified under “Coverage” = N/A on the Manage Reports page.

!image-20240805-173939.png|width=1155,height=119,alt="image-20240805-173939.png"!

Verified Form24: 24 HOUR REPORT OF INDEPENDENT EXPENDITURES sublabel is correct.

!image-20240805-174126.png|width=1198,height=212,alt="image-20240805-174126.png"!

Verified Form24: 248 HOUR REPORT OF INDEPENDENT EXPENDITURES sublabel is correct.

!image-20240805-174259.png|width=1316,height=205,alt="image-20240805-174259.png"!

QA Review Completed. Moved to Stage Ready.

exalate-issue-sync[bot] commented 2 weeks ago

Sprint accepted by Paul Clark during sprint review on 8/20/2024.

fecgov / fecfile-web-app