Fix the associating between Partnership Receipt Joint Fundraising Transfer Memo and second Partnership Attribution Joint Fundraising Transfer Memo

[exalate-issue-sync[bot]]

Where was the issue found:

Committee ID: C00100495

Environment: DEV / STAGE

Browser: Chrome

Please describe the issue: If a grandchild is created from another grandchild the “Associated with” is tied to the grandparent instead of the child transaction.

Approx. time the issue was found: 4:00 pm on 08/08/2024

How to replicate the issue:

1. Create Partnership Receipt Joint Fundraising Transfer Memo
2. Create Partnership Attribution Joint Fundraising Transfer Memo
3. From the first attribution memo transaction create a second Partnership Attribution Joint Fundraising Transfer Memo
4. The Associated With is tied to the grandparent instead of the child transaction. (This is the bug)

Screenshots:

Mitchell Jarrett Matt Travers Todd Lees Fix the associating between Partnership Receipt Joint Fundraising Transfer Memo (child) and second Partnership Attribution Joint Fundraising Transfer Memo (grandchild) created from another grandchild.

Bug found during Sprint 46 testing on DEV also verified on STAGE. Bug pointed 3 pts. assigned to Sprint 47.

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1520

[exalate-issue-sync[bot]]

Elaine Krauss commented: The error has been fixed, and a PR is ready for code review. The screenshot below has five transactions, one T1, one T2, and three T3 respectively, in the order they were created. You will see that all Tier 3 transactions are associated with the Tier 2 transaction.

!image-20240813-132533.png|width=1647,height=548,alt="image-20240813-132533.png"!

[exalate-issue-sync[bot]]

Passes CR. Sending to QA.

[exalate-issue-sync[bot]]

An issue came up with this ticket. Moving back to In Progress. A patch is in the works.

[exalate-issue-sync[bot]]

Ran into a problem scenario while testing 1502:

• open a tier 2 from list
• click “save & add memo” and pick a type on the same tier (like individual memo from individual memo)
• the url is now …/tier_2_id/create-sub-transaction/ so after saving the new memo is a sub transaction of what was supposed to be it’s sibling

I think this is coming from ANOTHER_CHILD vs CHILD. I think ideally we get rid of ANOTHER_CHILD and refactor navigation-control.component to use only CHILD or ANOTHER

[exalate-issue-sync[bot]]

issue from previous comment fixed in [https://github.com/fecgov/fecfile-web-app/pull/2115|https://github.com/fecgov/fecfile-web-app/pull/2115|smart-link]

[exalate-issue-sync[bot]]

fix for issue found after original pr was merged: https://github.com/fecgov/fecfile-web-app/pull/2115

[exalate-issue-sync[bot]]

Fix made in [https://fecgov.atlassian.net/browse/FECFILE-1502|https://fecgov.atlassian.net/browse/FECFILE-1502|smart-link].

Moving ticket back to QA.

[exalate-issue-sync[bot]]

Shelly Wise commented:

QA review verified bug fix.

Create Partnership Receipt Joint Fundraising Transfer Memo

Create Partnership Attribution Joint Fundraising Transfer Memo

From the first attribution memo transaction create a second Partnership Attribution Joint Fundraising Transfer Memo

The Associated With is tied to the grandparent instead of the child transaction. Bug fixed.

!image-20240820-172115.png|width=1458,height=672,alt="image-20240820-172115.png"! See image in Jira

QA Review Completed. Moved to Stage Ready.

[exalate-issue-sync[bot]]

Automation for Jira commented: Sprint accepted by Paul Clark at Sprint Review on comment date.