search

fecgov / fecfile-web-app

Other
7 stars 4 forks source link

Refactor navigation event handling in transaction form #2119

Open exalate-issue-sync[bot] opened 1 month ago

exalate-issue-sync[bot] commented 1 month ago

Simplify navigation event handling to avoid bugs and improve code maintainability.

Sasha has identified an improvement we can make in our transaction detail and container components on how we handle navigation events. We’re sort of juggling a NavigationEvent object across components, using variable binding + change detection in some cases and event firing + handling in others. Look into a way to consistently and clearly handle navigation events from different parts of the transaction component.

QA Notes

Ensure buttons on the transaction entry forms work as usual. E2e and unit tests passing will be presented to QA

DEV Notes

One option is to use a shared service

Design

null

See full ticket and images here: FECFILE-1535

exalate-issue-sync[bot] commented 5 days ago

Todd Lees commented: passes CR moving to QA

exalate-issue-sync[bot] commented 2 days ago

Todd Lees commented: Passes CR moving to QA

exalate-issue-sync[bot] commented 1 day ago

Elaine Krauss commented: Unit tests passing

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-app/6413/workflows/b9e58705-097c-4981-b00d-8715c328e91d/jobs/21981|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-app/6413/workflows/b9e58705-097c-4981-b00d-8715c328e91d/jobs/21981]

exalate-issue-sync[bot] commented 1 day ago

Shelly Wise commented: QA review verified Unit tests passing per DEV.

!image-20240917-133822.png|width=1315,height=452,alt="image-20240917-133822.png"!

QA Review Completed. Moved to Stage Ready.