[Alpha] System to designate a committee as PAC or PTY based on Form 1 field "committee_type"

[exalate-issue-sync[bot]]

Business Reason

For alpha, we must use the following logic to determine if we should show PAC or PTY transactions for a committee, since we will not have “processed” committee data.

Acceptance Criteria

Given a committee account

When the test form 1 data endpoint (https://api-stage.open.fec.gov/v1/efile/test-form1/) shows 'D' as committee_type

Then type will be ‘PTY’ and only PTY transactions will show,

Else (committee_type is NOT 'D') type will be ‘PAC’ and only PAC transactions will show.

QA Notes

PAC or PTY setting determines what transactions a user can see when adding transactions in Form 3X - see linked tickets below.

Two committees will be provided. One with committee type 'D' and one with another type.

DEV Notes

• Set PAC/PTY based on “committee_type” field in raw form 1 data (it is not well named, but that is the correct field).

Design

null

See full ticket and images here: FECFILE-1622

[exalate-issue-sync[bot]]

Todd Lees commented: [~accountid:61b0b42cd5986c006a9e1c94] should the PAC condition be an unspecified otherwise rather than C, E, F, F, H? The fec format says there are other options like A and B. We’d cover ourselves more comprehensively if the rule was D => PTY, anything else => PAC

[exalate-issue-sync[bot]]

akhorsand commented: Ideally, complete this ticket after we are hooked up to the test EFO data for Alpha.

[exalate-issue-sync[bot]]

Elaine Krauss commented: I’ve implemented the changes to determining PAC/PTY status based on Committee Type, and I’ve created a new type-D “Delegate” committee on DEV for myself and Shelly to make it easier to test

!image-20240924-154832.png|width=524,height=206,alt="image-20240924-154832.png"!

[exalate-issue-sync[bot]]

Elaine Krauss commented: For QA: the unit test results are [here|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-app/6519/workflows/0ecae5f6-5c09-4f94-a293-eb109e717313/jobs/22274/parallel-runs/0/steps/0-111]

[exalate-issue-sync[bot]]

gregg.moreland commented: [~accountid:712020:eaccd25d-427c-4e4d-a650-909ec0b31071] I will need something set up in Stage so that I can show this in a demo

[exalate-issue-sync[bot]]

Todd Lees commented: passes CR moving to QA

[exalate-issue-sync[bot]]

Todd Lees commented: [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] To test, please create a new committee account for C00101522. Create an f3x. If you go to create a disbursement, you should see the options that are available to a party committee per [https://fecgov.atlassian.net/browse/FECFILE-581|https://fecgov.atlassian.net/browse/FECFILE-581|smart-link]

For example, if you weren’t a PTY, you’d be able to make a {{BUSINESS_LABOR_REFUND_NON_CONTRIBUTION_ACCOUNT}} disbursement.

!image-20240927-165951.png|width=673,height=207,alt="image-20240927-165951.png"!

BUT if you are a PTY committee, like C00101522, you won’t see that option:

!image-20240927-170025.png|width=795,height=177,alt="image-20240927-170025.png"!

[exalate-issue-sync[bot]]

Shelly Wise commented: [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] from your comment setting up stage for demo ? FYI - This ticket is Sprint 49 next demo is Sprint 48. FYI (but you may know this - just making sure 🙂 )