fecgov / fecfile-web-app

Other
7 stars 4 forks source link

[Update] System to inform user committee account cannot be created if their email does not match OR it already exists #2194

Open exalate-issue-sync[bot] opened 1 month ago

exalate-issue-sync[bot] commented 1 month ago

Business Reason

If the user's http://login.gov email does not match either of the Form 1 emails OR the committee account already exists, then the system will not let the user create a new committee account so that we do not create duplicates in the system. [Update] this check should happen BEFORE the result from the committee ID search is shown. Users should not see even if a committee exists.

Acceptance Criteria

Given a provisioned user has selected "Create a new committee account" from the committee account selection screen, when they search for a committee using committee ID and either press enter or click the search icon, IF either of the following are true:

then the system will inform them there was an issue creating the committee, and they can either:

QA Notes

null

DEV Notes

null

Design

h2. Wireframes

!1509-S4.png|width=1365,height=884,alt="1509-S4.png"!

See full ticket and images here: FECFILE-1633

exalate-issue-sync[bot] commented 1 month ago

akhorsand commented: [~accountid:5b93ddba73130a2b8c662e23] [~accountid:61b0b42cc510bc006b5c03ed] ticket to fix when the system checks the user email against the committee ID during the account search/creation process. This will ensure that if they don’t have the ability to create or join an account, no result shows up.

exalate-issue-sync[bot] commented 1 month ago

Todd Lees commented: per the design suggestion above:

{quote}{color:#ff5630}Should the error message be updated to “Unable to locate committee account” or something to imply that it’s not just an account creation issue, and is even more vague?{color}{quote}

That seems problematic. When the error was the result of clicking “create account” the error language was something like “unable to create account”, which was vague but also true. If we throw the error when they search and say “Unable to locate committee account” it’s specific and in many cases untrue.

exalate-issue-sync[bot] commented 1 month ago

Mitchell Jarrett commented: [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] the vagueness was at the direction of Laura and Ryan

exalate-issue-sync[bot] commented 1 month ago

Mitchell Jarrett commented: [~accountid:5b93ddba73130a2b8c662e23] [~accountid:61b0b42cd5986c006a9e1c94] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62]

PLS review

exalate-issue-sync[bot] commented 1 month ago

Todd Lees commented: [~accountid:61b0b42cc510bc006b5c03ed] I’m aware of the intended vagueness. I think “Unable to create account” is the correct message as it is vague and true. My statement was that the message “Unable to locate committee account” is not vague and rather specific and often inaccurate (not true). vague is true and not specific.

The ticket seems to be ready except

{quote}[Update] this check should happen BEFORE the result from the committee ID search is shown. Users should not see even if a committee exists.{quote}

My understanding is that the check happens as a RESULT of the search. As in the user types in the id, hits enter or the search button and THEN the check happens. The update is that the check happens before the ‘create’ action.