fecgov / fecfile-web-app

Other
6 stars 4 forks source link

UAT: Remove "aggregate" and "itemize" actions from IE transactions on Form 24 #2207

Closed exalate-issue-sync[bot] closed 3 weeks ago

exalate-issue-sync[bot] commented 1 month ago

Where was the issue found:

Please describe the issue clearly and concisely (e.g., expected vs. actual result):

The “itemize” action is available on the Form 24 transactions when it should not be per https://fecgov.atlassian.net/browse/FECFILE-512. The requirements were undone in https://fecgov.atlassian.net/browse/FECFILE-1458 but need to revert back to the following ACs:

Given a SE transaction on a Form 24,

When the user selects the action kabob next to the transaction on the transactions table,

Then they will not see the following actions:

Approximate time the issue was found: UAT testing

Steps to Reproduce:

Add/see relevant screenshots in "Design" section below.

(NOTE: QA review notes below showing this error Found in Form 3x disbursments from a Form 24 IE)

QA Notes

It may be worth checking with dev to see how this affects FECFILE-480. That may need to be retested.

Note this is only for Form 24 transactions.

DEV Notes

Note this is only for Form 24 transactions.

Design

null

See full ticket and images here: FECFILE-1640

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: [~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] Defect found during Sprint 48. Retested and verified defect for Form 24 fixes. This tested when Form 24 linked to Form 3x the dropdown in displayed incorrectly per the AC. The dropdown only shows edit and delete for and IE on a Form 24.. Per earlier conversation moved to Sprint Backlog for Sprint 49 and pointed 2 points.

exalate-issue-sync[bot] commented 1 month ago

David Heitzer commented: [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] I tried reproducing this in stage and dev and am not seeing the issue. Can you send a committee and report id that you’re seeing this in? Thanks.

!image-20241001-175125.png|width=2045,height=1092,alt="image-20241001-175125.png"!

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: [~accountid:712020:005cf740-faa3-4d67-baff-f316981bdc9f] below screenshot. Create a Form 24, link to Form 3x. View form 3x disbursements, the Form 24 shows the following in the dropdown.

!image-20241001-190424.png|width=1229,height=439,alt="image-20241001-190424.png"!

Let me know if you need anything else, the ticket came from UAT, sorry should have updated AC. Thanks

exalate-issue-sync[bot] commented 1 month ago

Shelly Wise commented: [~accountid:712020:005cf740-faa3-4d67-baff-f316981bdc9f] [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] per conversation and clarification on this ticket. The Form 3x with a linked Form 24 should not show the following in the dropdown.

!image-20241001-200207.png|width=1292,height=217,alt="image-20241001-200207.png"!

Viewing a Form 24 this issue is not displaying for an IE.

!image-20241001-200335.png|width=1210,height=303,alt="image-20241001-200335.png"!

Thanks for the clarification.

exalate-issue-sync[bot] commented 1 month ago

David Heitzer commented: [~accountid:61b0b42cd5986c006a9e1c94] Per discussion with [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] and [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] yesterday this ticket is to remove force itemize/unitemize + aggregate/unaggregate from F3X SEs linked to F24. [This other ticket|https://github.com/fecgov/fecfile-web-app/issues/1381] however was to add aggregate/unaggregate in this scenario so I just wanted to make sure we didn’t undo something required. Holding off completing this until I confirm. Thanks.

exalate-issue-sync[bot] commented 1 month ago

akhorsand commented: Moving back to AA to get clarification from FEC. Confirmed with [~accountid:61b0b42cc510bc006b5c03ed] that this will be out of Sprint 49 and planned for 50.

[~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] we need to confirm that from the Form 24, the user cannot force itemize/unitemize or force aggregate/disaggregate the IE. However, those actions are available on the Form 3X IEs.

exalate-issue-sync[bot] commented 4 weeks ago

gregg.moreland commented: [~accountid:61b0b42cd5986c006a9e1c94] From a Form 24, the only actions available on a transaction are Edit and Delete. Itemize and Aggregate are not available from a Form 24. From a Form 3X, those are available. From discussion with Ryan last week, Aggregate should still be allowed from Form 3X, but there is still a question about whether ALL IE’s should be itemized on Form 3X. Definitely, Void transactions should all be itemized, regardless of the amount. Either this ticket should be closed or it should be changed to reflect what needs to be done in Form 3X

exalate-issue-sync[bot] commented 3 weeks ago

akhorsand commented: Closing this particular defect as “cannot reproduce”. We will address updating itemization logic for IEs and voids in a separate ticket if needed.