fecgov / fecfile-web-app

Other
6 stars 4 forks source link

Remove code to support the old debug login from our app and api #2234

Open exalate-issue-sync[bot] opened 1 month ago

exalate-issue-sync[bot] commented 1 month ago

Now that login.gov login is being utilized by the e2e tests, we no longer have a need for the legacy debug login. This ticket is to remove the code associated with this functionality from the app and api.

With no debug login, we can update the login page to behave the same as on local as it does on deployed instances

E2E tests will need to be confirmed and updated if necessary

Remove unused user data/columns in user records on db (model changes and migrations). Make sure e2e test captures using the center “sign in” button on the screen.

Remove app/api dependencies if necessary.

QA Notes

Screenshot to confirm that the local login page no longer contains debug login form.

Need to have e2e and unit tests showing as passing.

DEV Notes

The debug login functionality will need to be removed in at least the following ways (we should take this opportunity to cleanup any other areas associated with the legacy login functionality that are found):

Design

null

See full ticket and images here: FECFILE-1671

exalate-issue-sync[bot] commented 5 days ago

David Heitzer commented: also https://github.com/fecgov/fecfile-web-api/pull/1215

exalate-issue-sync[bot] commented 5 days ago

Todd Lees commented: [https://app.circleci.com/pipelines/github/fecgov/fecfile-web-app/6980/workflows/d586a8bf-ea04-4e92-a7ef-c7612d4cba80/jobs/23714|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-app/6980/workflows/d586a8bf-ea04-4e92-a7ef-c7612d4cba80/jobs/23714]

!image-20241121-203304.png|width=965,height=568,alt="image-20241121-203304.png"!

exalate-issue-sync[bot] commented 5 days ago

Todd Lees commented: passes cr moving to qa

exalate-issue-sync[bot] commented 5 days ago

Shelly Wise commented: QA review verified as test pass per DEV for this ticket.

!image-20241121-210202.png|width=1001,height=588,alt="image-20241121-210202.png"!

QA Review Completed. Moved to Stage Ready.