System to update dynamic Contribution Purpose Description if linked transaction is edited and saved

AureliaKhorsand commented 2 years ago

Business Reason

As a Committee Administrator, I will be able to update details in a transaction that are used in a linked transaction's Contribution Purpose Description so that I can see the system automatically update the Contribution Purpose Description in the linked transaction to reflect the change.

Acceptance Criteria

Given a transaction with a dynamic Contribution Purpose Description (for example, JF Transfer/PAC JF Transfer Memo)

If I update the Contributor name (individual name, org name, committee name) in the transaction being pulled from,

When I save the transaction

Then the Contribution Purpose Description in the linked transaction will reflect the change.

QA Notes

JF Transfer/PAC JF Transfer Memo is a transaction pairing with this situation.

DEV Notes

Several transactions are defined to use the contributor name (individual/org/committee) of another transaction as part of the Contribution Purpose Description. For example: The Contributor Committee name in the JF Transfer transaction is displayed in the JF Transfer Memo Contribution Purpose Description - if the Contributor Committee name in the main transaction is changed, then it should be updated in the memo transaction.

This system update should apply to all future transactions created with a similar dynamic link.

This will need to be done on the back-end.

Earmark Receipt/Memo CPD's already reflect changes since they are on the same page and are saved in tandem.

Design

null

See full ticket and images here: FECFILE-1140

Elaine-Krauss-TCG commented 1 year ago

@AureliaKhorsand

Bit of a broad question here: are there any future transaction types that would want their purpose descriptions updated dynamically but would not fall under the parent-child relationship?

mjtravers commented 1 year ago

Passes CR. Sending to QA.

WiseQA commented 1 year ago

QA review cannot complete testing as error is displayed when creating and saving a "memo" with JF Transfer.

@mjtravers @MitchellTCG This is the same bug reported in #609.

Returned to In-Progress.

WiseQA commented 1 year ago

@mjtravers - Bug created for "When adding a memo and select "Save and add another memo" button" receive error. This bug impacts several tickets in the pipeline.

https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/gh/fecgov/fecfile-web-api/320

This ticket returned to QA Review as this ticket passes functionality as written.

WiseQA commented 1 year ago

QA review verified the system automatically updated the Contribution Purpose Description with edit changes.

Joint Fundraising Transfer - National Party Headquarters Buildings Account

PAC National Party Headquarters Buildings Account JF Transfer Memo

PAC National Party Headquarters Buildings Account JF Transfer Memo Contribution Purpose Description edited "added word Update".

QA Review Completed. Moved to Stage Ready.

mjtravers commented 1 year ago

The fix for #320 has corrected the bug. Ready for retesting on DEV.

MitchellTCG commented 1 year ago

Thanks so much @mjtravers https://github.com/mjtravers for knocking this out.

On Wed, Jan 25, 2023 at 7:13 PM Matt Travers @.***> wrote:

The fix for #320 https://app.zenhub.com/workspaces/fecfile-online-619e578e68408b001c831251/issues/gh/fecgov/fecfile-web-api/320 has corrected the bug. Ready for retesting on DEV.

— Reply to this email directly, view it on GitHub https://github.com/fecgov/fecfile-web-app/issues/371#issuecomment-1404387572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDHDVXTQKFIQ7RB3BU22KDWUG6R5ANCNFSM52XB244A . You are receiving this because you were mentioned.Message ID: @.***>

-- H. Mitchell Jarrett, CSP-SM, CSPO Agile Project Manager TCG, Inc. - Positively Distinct - CMMI-DEV Level 3 - CMMI-SVC Level 2 - ISO 9001:2008 Tel: 202.395.2462 | Mobile: 202.270.1935 | @.*** | www.tcg.com https://www.facebook.com/TCG-32241785903 https://twitter.com/TCGnews [image: Linkedin] https://www.linkedin.com/in/mitchell-jarrett-4610096

WiseQA commented 1 year ago

QA review retested the Contribution Purpose Description (System-Generated) if the parent name is edited and saved.

Contribution Purpose Description Name - Headquarters Buildings Account JF Memo: National Party Headquarters Buildings Account Retest

Contribution Purpose Description Name edited and saved - Headquarters Buildings Account JF Memo: National Party Headquarters Buildings Account Retest Changed

QA Review retest completed. Tested and passes as denoted in ticket.

fecgov / fecfile-web-app