fecgov / fecfile-web-app

Other
7 stars 4 forks source link

System to save Transaction Memo Text as separate TEXT record #403

Closed AureliaKhorsand closed 1 year ago

AureliaKhorsand commented 2 years ago

Business Reason

As a user, I will be able to enter additional information for a transaction in the Memo Text field of a transaction and it will save as a Text record associated with the transaction so that I can have more space for my documentation.

Acceptance Criteria

Given the user is creating or editing a transaction

Then they will have the option to enter Memo Text (A/N, 4000)

And when they save the transaction, the Memo Text will be saved as a TEXT record associated with that transactions.

And the TEXT record row will be saved in the *.fec file directly beneath the transaction row.

QA Notes

The screenshot of the fec file has been replaced here with a file that can be downloaded and opened with MS Notepad: The .fec generated in testing. (Click on this link new one generated after some last minute revisions to .fec generation) It was renamed to have a .txt extension because Zenhub does not allow the .fec extension for some reason...

Transactions that need testing (as of 10/13/22)

DEV per meeting last week, please add screen shot of .fec file in QA notes what needs verified. Also, if there is an order to the output in .fec file please denote in QA notes for testing purposes.

DEV Notes

Design

null

See full ticket and images here: FECFILE-1127

AureliaKhorsand commented 2 years ago

Per Ryan via Slack on 7/19/22: In OP2 my preference would be that we ignore Field 44 in the .fec and instead output any text in the Memo Text Description box to the Text field in the .fec with a backreference to the specific transaction. This will allow the filer to provide additional information, which may be needed for some transactions, specifically multi-state IEs. Please let me know if anyone has any comments or questions on this one. Below I have provided some additional information in regards to the two different memo texts that exist in the format specifications (.fec files).”

See notes with screenshot here.

mjtravers commented 1 year ago

Changes requested in CR. Sending to In Progress.

Elaine-Krauss-TCG commented 1 year ago

A .fec generated with this ticket

image.png

mjtravers commented 1 year ago

Some requests from CR. Sending back to In Progress

WiseQA commented 1 year ago

@mjtravers @MitchellTCG what was the changes sent back to In-progress or does it matter to QA ? Also is there a pattern I need to see in the response from .fec ? or does it matter on the order of things being posted ?

Elaine-Krauss-TCG commented 1 year ago

@WiseQA

The changes requested as part of CR mostly reflected code changes that needed to be made in order to have the cleanest possible solution rather than anything that a user would be able to observe.

The generated .fec should have the memo text descriptions present on their own separate lines immediately following their respective transactions per the ticket requirements

mjtravers commented 1 year ago

Passes CR. Sending to QA.

WiseQA commented 1 year ago

QA verified .fec file is downloadable, and viewable as denoted in acceptance criteria. (Note downloaded to NotePad)

image.png

QA Review Completed. Moved to Stage Ready.