fecgov / fecfile-web-app

Other
7 stars 4 forks source link

Allow user to enter Unregistered Receipt from Person - Returned/Bounced Receipt on Schedule A (Group D) #489

Closed GreggMoreland closed 1 year ago

GreggMoreland commented 2 years ago

Business Reason

As a Committee Administrator, I will be able to enter a ” Unregistered Receipt from Person - Returned/Bounced Receipt” transaction on Schedule A of a Form 3X report so that I can accurately report on my committee's transactions.

Acceptance Criteria

Given I am a Committee Administrator editing an open Form 3X report Then Add a new transaction Then Click(open) on the "Contributions from Individuals/Persons" Accordion link
Then I can enter a transaction with the type “Unregistered Receipt from Person - Returned/Bounced Receipt" Then I will be required to enter the following information (unless otherwise noted):


Contact

#

Address

#

Receipt Information

#

Additional information

#


Then I will be able to:

And the transaction will be itemized upon saving and saved with it's own line item on the *.fec file.

Dev Note

See Schedule A spec here.

#

See Unregistered Receipt from Person - Returned/Bounced Receipt spec here.

#

QA Notes

AureliaKhorsand commented 1 year ago

@MitchellTCG @mary-tcg wireframes need updating. Please note label name changes and CPD requirements.

Elaine-Krauss-TCG commented 1 year ago

Transaction implemented, and it does not allow a positive value for contribution amount: image

Contribution Purpose Description is user-entered and required: (We might need to reconsider "Optional") image

The transaction is saving as expected image

The transaction is being itemized image

Elaine-Krauss-TCG commented 1 year ago

Transaction added to E2E testing coverage image

Elaine-Krauss-TCG commented 1 year ago

Added new error messages for exclusive maximum and exclusive minimum values image.png image.png

WiseQA commented 1 year ago

@AureliaKhorsand @MitchellTCG Ticket #512 denotes verbiage in acceptance criteria for Amount (see below) Note: AMOUNT MUST be a non-zero negative value. Max value is -0.01. If amount is higher than than, then display error message 'Amount must be negative'

Also verbiage for Contribution Purpose Description.

@AureliaKhorsand @GreggMoreland @MitchellTCG should the verbiage be the same for this ticket ? If so can we denote in Acceptance Criteria correct verbiage to be consistent across tickets. Thanks !

MitchellTCG commented 1 year ago

@Elaine-Krauss-TCG I am moving this out of CR and back to in progress til the error language is vetted by Jonella. This will be done at the 1pm UX meeting today.

Elaine-Krauss-TCG commented 1 year ago

The error text for when a negative value is expected has been updated image.png THIS COMMENT AND CHANGE IS OBE DUE TO FUNCTIONALITY CHANGE. DISREGARD THIS CHANGE.

mjtravers commented 1 year ago

Passes CR. Sending to QA.

WiseQA commented 1 year ago

QA review verified Unregistered Receipt from Person - Returned/Bounced Receipt transaction is created and is editable once saved.

image.png

@mjtravers per discussion with Mitchell this ticket being returned to fix "Amount" field where negative must appear on initial key stroke not after tabbing.

mjtravers commented 1 year ago

The new handling of the negative amount has been implemented and passes CR. Sending to QA.

WiseQA commented 1 year ago

QA review retested the Unregistered Receipt from Person - Returned/Bounced Receipt.

image.png

Verified when entering $0.00 amount the following message appears below amount field.

image.png

Verified when entering "Amount" field negative appears on initial key stroke not after tabbing.

image.png

QA Review Completed. Moved to Stage Ready.