fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

[MERGE WITH GIT FLOW] Hotfix/handle no issue date #1998

Closed anthonygarvan closed 7 years ago

anthonygarvan commented 7 years ago

This also includes a minor fix to make citation urls work.

codecov-io commented 7 years ago

Codecov Report

Merging #1998 into master will decrease coverage by 0.06%. The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   56.11%   56.05%   -0.07%     
==========================================
  Files          48       48              
  Lines        3220     3231      +11     
  Branches      370      374       +4     
==========================================
+ Hits         1807     1811       +4     
- Misses       1413     1420       +7
Impacted Files Coverage Δ
openfecwebapp/views.py 42.85% <0%> (-0.35%) :arrow_down:
static/js/legal/SearchResults.js 38.46% <33.33%> (-1.54%) :arrow_down:
static/js/legal/LegalSearch.js 88.23% <50%> (-3.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44a4f60...347e2dd. Read the comment docs.

vrajmohan commented 7 years ago

Looks good. As it is the end of the week, we'll merge it on Monday.