noahmanger commented 7 years ago

As reported in https://github.com/18F/FEC/issues/4032, the House Candidates page is missing the state (and district) filter. I looked into it and the template code was already there, but it was using the wrong variable to check the office. So this is just a small fix to restore the original designed functionality:

Resolves https://github.com/18F/FEC/issues/4032

This also includes a small fix to restore the details panels when looking at raw receipts data.

codecov-io commented 7 years ago

Codecov Report

Merging #2000 into develop will increase coverage by 0.58%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2000      +/-   ##
===========================================
+ Coverage    55.74%   56.32%   +0.58%     
===========================================
  Files           48       48              
  Lines         3231     3416     +185     
  Branches       374      445      +71     
===========================================
+ Hits          1801     1924     +123     
- Misses        1420     1482      +62     
  Partials        10       10

Impacted Files	Coverage Δ
openfecwebapp/routes.py	`44.68% <ø> (ø)`	:arrow_up:
static/js/legal/LegalSearch.js	`88.4% <0%> (+0.17%)`	:arrow_up:
static/js/modules/column-helpers.js	`24.41% <0%> (+0.73%)`	:arrow_up:
static/js/modules/tables.js	`57.37% <0%> (+3.55%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98eb24d...2d98e0e. Read the comment docs.

LindsayYoung commented 7 years ago

thanks

fecgov / openFEC-web-app

Pass office to template to restore correct filters #2000

Codecov Report